commit a1881f222dd5d43a992a21b3d7fa463fc190a4e7
author Jonas Devlieghere <jonas@devlieghere.com> Wed Feb 13 00:32:21 2019 +0000
committer Jonas Devlieghere <jonas@devlieghere.com> Wed Feb 13 00:32:21 2019 +0000
tree 4f411c92fb8c3fd9eec710eb3de3b288edb78a52
parent 629efa3c8d69c8d504db299168c7ef0f9c73270e

[dsymutil] Improve readability of cloneAllCompileUnits (NFC)

Add some newlines and improve consistency between the two loops.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@353904 91177308-0d34-0410-b5e6-96231b3b80d8

tools/dsymutil/DwarfLinker.cpp

diff --git a/tools/dsymutil/DwarfLinker.cpp b/tools/dsymutil/DwarfLinker.cpp
index ce86531..3fe018a 100644
--- a/tools/dsymutil/DwarfLinker.cpp
+++ b/tools/dsymutil/DwarfLinker.cpp
@@ -2242,7 +2242,9 @@
       cloneDIE(InputDIE, DMO, *CurrentUnit, StringPool, 0 /* PC offset */,
                11 /* Unit Header size */, 0, CurrentUnit->getOutputUnitDIE());
     }
+
     Linker.OutputDebugInfoSize = CurrentUnit->computeNextUnitOffset();
+
     if (Linker.Options.NoOutput)
       continue;
 
@@ -2251,9 +2253,12 @@
     // actually exist in the DIE tree.
     if (LLVM_LIKELY(!Linker.Options.Update) || Linker.Options.Translator)
       Linker.patchLineTableForUnit(*CurrentUnit, DwarfContext, Ranges, DMO);
+
     Linker.emitAcceleratorEntriesForUnit(*CurrentUnit);
-    if (Linker.Options.Update)
+
+    if (LLVM_UNLIKELY(Linker.Options.Update))
       continue;
+
     Linker.patchRangesForUnit(*CurrentUnit, DwarfContext, DMO);
     Linker.Streamer->emitLocationsForUnit(*CurrentUnit, DwarfContext);
   }
@@ -2265,11 +2270,14 @@
   for (auto &CurrentUnit : CompileUnits) {
     if (LLVM_LIKELY(!Linker.Options.Update))
       Linker.generateUnitRanges(*CurrentUnit);
+
     CurrentUnit->fixupForwardReferences();
-    if (CurrentUnit->getOutputUnitDIE()) {
-      Linker.Streamer->emitCompileUnitHeader(*CurrentUnit);
-      Linker.Streamer->emitDIE(*CurrentUnit->getOutputUnitDIE());
-    }
+
+    if (!CurrentUnit->getOutputUnitDIE())
+      continue;
+
+    Linker.Streamer->emitCompileUnitHeader(*CurrentUnit);
+    Linker.Streamer->emitDIE(*CurrentUnit->getOutputUnitDIE());
   }
 }