commit 655bef92b0cd0d693e2fff0a17a7b1c78b3b95d3
author Robert Widmann <devteam.codafi@gmail.com> Tue Jan 08 06:23:22 2019 +0000
committer Robert Widmann <devteam.codafi@gmail.com> Tue Jan 08 06:23:22 2019 +0000
tree a8fc662abac4953993c2e2a70911d828ddfe3dbb
parent 15c70a3ec3081a4d6a1a35f65be7b6b654a609e1

[LLVM-C] Allow Specifying Signedness in Int Cast

Summary: Fix an old outstanding problem with the int cast builder binding always assuming the cast is signed by introducing a new LLVMBuildIntCast2 operation and deprecating the old prototype.

Reviewers: whitequark, deadalnix

Reviewed By: whitequark

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D56280

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@350607 91177308-0d34-0410-b5e6-96231b3b80d8

include/llvm-c/Core.h

diff --git a/include/llvm-c/Core.h b/include/llvm-c/Core.h
index 00911fe..264cf83 100644
--- a/include/llvm-c/Core.h
+++ b/include/llvm-c/Core.h
@@ -3633,11 +3633,16 @@
                            LLVMTypeRef DestTy, const char *Name);
 LLVMValueRef LLVMBuildPointerCast(LLVMBuilderRef, LLVMValueRef Val,
                                   LLVMTypeRef DestTy, const char *Name);
-LLVMValueRef LLVMBuildIntCast(LLVMBuilderRef, LLVMValueRef Val, /*Signed cast!*/
-                              LLVMTypeRef DestTy, const char *Name);
+LLVMValueRef LLVMBuildIntCast2(LLVMBuilderRef, LLVMValueRef Val,
+                               LLVMTypeRef DestTy, LLVMBool IsSigned,
+                               const char *Name, size_t NameLen);
 LLVMValueRef LLVMBuildFPCast(LLVMBuilderRef, LLVMValueRef Val,
                              LLVMTypeRef DestTy, const char *Name);
 
+/** Deprecated: This cast is always signed. Use LLVMBuildIntCast2 instead. */
+LLVMValueRef LLVMBuildIntCast(LLVMBuilderRef, LLVMValueRef Val, /*Signed cast!*/
+                              LLVMTypeRef DestTy, const char *Name);
+
 /* Comparisons */
 LLVMValueRef LLVMBuildICmp(LLVMBuilderRef, LLVMIntPredicate Op,
                            LLVMValueRef LHS, LLVMValueRef RHS,

lib/IR/Core.cpp

diff --git a/lib/IR/Core.cpp b/lib/IR/Core.cpp
index 4064b67..921c830 100644
--- a/lib/IR/Core.cpp
+++ b/lib/IR/Core.cpp
@@ -3534,6 +3534,13 @@
   return wrap(unwrap(B)->CreatePointerCast(unwrap(Val), unwrap(DestTy), Name));
 }
 
+LLVMValueRef LLVMBuildIntCast2(LLVMBuilderRef B, LLVMValueRef Val,
+                               LLVMTypeRef DestTy, LLVMBool IsSigned,
+                               const char *Name, size_t NameLen) {
+  return wrap(unwrap(B)->CreateIntCast(unwrap(Val), unwrap(DestTy),
+                                       IsSigned, StringRef(Name, NameLen)));
+}
+
 LLVMValueRef LLVMBuildIntCast(LLVMBuilderRef B, LLVMValueRef Val,
                               LLVMTypeRef DestTy, const char *Name) {
   return wrap(unwrap(B)->CreateIntCast(unwrap(Val), unwrap(DestTy),