commit ca995c14f7be9b05025f70d17fde059ae5c39bec
author Sanjay Patel <spatel@rotateright.com> Fri Aug 05 11:51:59 2022 -0400
committer Copybara-Service <copybara-worker@google.com> Fri Aug 05 09:09:56 2022 -0700
tree 4b7ca6e3d9c92e6287fdcac4ad2a14467ad79878
parent 8471f8a6a1530d4d08a1ce879f6f7b516a314ab2

[InstSimplify] make uses of isImpliedCondition more efficient (NFCI)

As suggested in the post-commit comments for 019d76196f79fcff3c148,
this makes the usage symmetric with the 'and' patterns and should
be more efficient.

GitOrigin-RevId: b63fc26d33e16698e015d5942b4065fbacf44909

lib/Analysis/InstructionSimplify.cpp

diff --git a/lib/Analysis/InstructionSimplify.cpp b/lib/Analysis/InstructionSimplify.cpp
index 9578360..30b9c6e 100644
--- a/lib/Analysis/InstructionSimplify.cpp
+++ b/lib/Analysis/InstructionSimplify.cpp
@@ -2421,23 +2421,19 @@
       return V;
 
   if (Op0->getType()->isIntOrIntVectorTy(1)) {
-    // If Op0 is true implies Op1 is true, then Op0 is a subset of Op1.
-    if (Optional<bool> Implied = isImpliedCondition(Op0, Op1, Q.DL)) {
-      if (*Implied == true)
-        return Op1;
-    }
-    // If Op0 is false implies Op1 is true, then at least one is always true.
     if (Optional<bool> Implied = isImpliedCondition(Op0, Op1, Q.DL, false)) {
+      // If Op0 is false implies Op1 is false, then Op1 is a subset of Op0.
+      if (*Implied == false)
+        return Op0;
+      // If Op0 is false implies Op1 is true, then at least one is always true.
       if (*Implied == true)
         return ConstantInt::getTrue(Op0->getType());
     }
-    // If Op1 is true implies Op0 is true, then Op1 is a subset of Op0.
-    if (Optional<bool> Implied = isImpliedCondition(Op1, Op0, Q.DL)) {
-      if (*Implied == true)
-        return Op0;
-    }
-    // If Op1 is false implies Op0 is true, then at least one is always true.
     if (Optional<bool> Implied = isImpliedCondition(Op1, Op0, Q.DL, false)) {
+      // If Op1 is false implies Op0 is false, then Op0 is a subset of Op1.
+      if (*Implied == false)
+        return Op1;
+      // If Op1 is false implies Op0 is true, then at least one is always true.
       if (*Implied == true)
         return ConstantInt::getTrue(Op1->getType());
     }