commit a0c02ff888f1311da28910df079241f1ffc24491
author Martin Storsjö <martin@martin.st> Wed Aug 03 11:04:51 2022 +0300
committer Copybara-Service <copybara-worker@google.com> Thu Aug 04 01:22:10 2022 -0700
tree b35035feff664b5cc1e97cb8e078addfa8572a77
parent 14151322ed7c4f96d2f0875d5ed0ec7bce51e292

[ORC] Actually propagate memory unmapping errors on Windows

This fixes warnings like these:

    ../lib/ExecutionEngine/Orc/MemoryMapper.cpp:364:9: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
            joinErrors(std::move(Err),
            ^~~~~~~~~~ ~~~~~~~~~~~~~~~

Differential Revision: https://reviews.llvm.org/D131056

GitOrigin-RevId: 46bc1b5689e417d870c57a8d16044a55549673fa

lib/ExecutionEngine/Orc/MemoryMapper.cpp

diff --git a/lib/ExecutionEngine/Orc/MemoryMapper.cpp b/lib/ExecutionEngine/Orc/MemoryMapper.cpp
index fdfdffc..ee92e51 100644
--- a/lib/ExecutionEngine/Orc/MemoryMapper.cpp
+++ b/lib/ExecutionEngine/Orc/MemoryMapper.cpp
@@ -361,8 +361,8 @@
 #elif defined(_WIN32)
 
       if (!UnmapViewOfFile(Reservations[Base].LocalAddr))
-        joinErrors(std::move(Err),
-                   errorCodeToError(mapWindowsError(GetLastError())));
+        Err = joinErrors(std::move(Err),
+                         errorCodeToError(mapWindowsError(GetLastError())));
 
 #endif