commit 924596ce72779950014d359db455b4db8d26b318
author Kazu Hirata <kazu@google.com> Sun Oct 01 15:53:53 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Sun Oct 01 15:57:00 2023 -0700
tree 2603e36a35aeba3151040b7cddd876b50809ff91
parent cd128ffea0f1cf5dfa70ff30e21d06c752a56cf4

[ExecutionEngine] Fix the call to DWARFContext::create

Without this patch, we pass G.getEndianness() as one of the parameters
to DWARFContext::create.  The problem is that G.getEndianness() is of:

  enum endianness {big, little, native};

whereas DWARFContext::create is expecting "bool isLittleEndian".  That
is, we are relying on an implicit conversion to convert big and little
to false and true, respectively.

When we migrate llvm::support::endianness to std::endian in future, we
can no longer rely on an implicit conversion because std::endian is
declared with "enum class".  Even if we could, the conversion would
not be guaranteed to work because, for example, libcxx defines:

  enum class endian {
    little = 0xDEAD,
    big = 0xFACE,
    :

where big and little are not boolean values.

This patch fixes the problem by properly converting G.getEndianness()
to a boolean value.

GitOrigin-RevId: 8de2ecc2e75d496fc7fc8a24c3acf71732a3bd0c

lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp

diff --git a/lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp b/lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp
index 13a0f83..2f70a11 100644
--- a/lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp
+++ b/lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp
@@ -158,8 +158,12 @@
 
     std::optional<StringRef> FileName;
     if (!DebugLineSectionData.empty()) {
+      assert((G.getEndianness() == support::endianness::big ||
+              G.getEndianness() == support::endianness::little) &&
+             "G.getEndianness() must be either big or little");
       auto DWARFCtx = DWARFContext::create(DebugSectionMap, G.getPointerSize(),
-                                           G.getEndianness());
+                                           G.getEndianness() ==
+                                               support::endianness::little);
       DWARFDataExtractor DebugLineData(
           DebugLineSectionData,
           G.getEndianness() == support::endianness::little, G.getPointerSize());