commit 4e273d7b68c24bb257e37af27d8834dc23eea479
author Lang Hames <lhames@gmail.com> Fri Aug 05 12:03:34 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Aug 05 13:56:23 2022 -0700
tree 7b59d4cf3e5326b419717d669cc5edb9b1420055
parent 5a9de88a6ccf7e05d04a0d6fe8780421b20fd906

[ORC] Fix a memory leak in LLVMOrcIRTransformLayerSetTransform.

This function heap-allocates a ThreadSafeModule (the current C bindings assume
that TSMs are always heap-allocated), but was failing to free it.

Should fix http://llvm.org/PR56953.

GitOrigin-RevId: bc062e034fbdb5674fc26d354ef5b4c236aab640

lib/ExecutionEngine/Orc/OrcV2CBindings.cpp

diff --git a/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp b/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
index b7eab6b..6575bf3 100644
--- a/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
+++ b/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
@@ -892,7 +892,10 @@
               assert(!TSMRef && "TSMRef was not reset to null on error");
               return unwrap(Err);
             }
-            return std::move(*unwrap(TSMRef));
+            assert(TSMRef && "Transform succeeded, but TSMRef was set to null");
+            ThreadSafeModule Result = std::move(*unwrap(TSMRef));
+            LLVMOrcDisposeThreadSafeModule(TSMRef);
+            return std::move(Result);
           });
 }