commit 1e5e8ca7729916761be82d5bd5d01a11d654c3e8
author Lang Hames <lhames@gmail.com> Wed Aug 03 17:42:17 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Aug 03 17:58:26 2022 -0700
tree 2f0bc6a5d149bd3997bf8cbb945d0aa541215bcd
parent 2903486d4a30e4dfd3954fcece7024364908690d

[ORC] Ensure that llvm_orc_registerJITLoaderGDBAllocAction is linked into tools.

Add a reference to llvm_orc_registerJITLoaderGDBAllocAction from the
linkComponents function in the lli, llvm-jitlink, and llvm-jitlink-executor
tools. This ensures that llvm_orc_registerJITLoaderGDBAllocAction is not
dead-stripped in optimized builds, which may cause failures in these tools.

The llvm_orc_registerJITLoaderGDBAllocAction function was originally added with
MachO debugging support in 69be352a1961a, but that patch failed to update the
linkComponents functions.

http://llvm.org/PR56817

GitOrigin-RevId: b5f76d83ff8b57b2a6e4897beb388837803643da

include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.h

diff --git a/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.h b/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.h
index cfb9511..99175d7 100644
--- a/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.h
+++ b/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderGDB.h
@@ -19,4 +19,7 @@
 extern "C" llvm::orc::shared::CWrapperFunctionResult
 llvm_orc_registerJITLoaderGDBWrapper(const char *Data, uint64_t Size);
 
+extern "C" llvm::orc::shared::CWrapperFunctionResult
+llvm_orc_registerJITLoaderGDBAllocAction(const char *Data, size_t Size);
+
 #endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERGDB_H

tools/lli/lli.cpp

diff --git a/tools/lli/lli.cpp b/tools/lli/lli.cpp
index 42bea1a..3fd2a61 100644
--- a/tools/lli/lli.cpp
+++ b/tools/lli/lli.cpp
@@ -291,7 +291,8 @@
 LLVM_ATTRIBUTE_USED void linkComponents() {
   errs() << (void *)&llvm_orc_registerEHFrameSectionWrapper
          << (void *)&llvm_orc_deregisterEHFrameSectionWrapper
-         << (void *)&llvm_orc_registerJITLoaderGDBWrapper;
+         << (void *)&llvm_orc_registerJITLoaderGDBWrapper
+         << (void *)&llvm_orc_registerJITLoaderGDBAllocAction;
 }
 
 //===----------------------------------------------------------------------===//

tools/llvm-jitlink/llvm-jitlink-executor/llvm-jitlink-executor.cpp

diff --git a/tools/llvm-jitlink/llvm-jitlink-executor/llvm-jitlink-executor.cpp b/tools/llvm-jitlink/llvm-jitlink-executor/llvm-jitlink-executor.cpp
index 7100c27..34246ca 100644
--- a/tools/llvm-jitlink/llvm-jitlink-executor/llvm-jitlink-executor.cpp
+++ b/tools/llvm-jitlink/llvm-jitlink-executor/llvm-jitlink-executor.cpp
@@ -39,7 +39,8 @@
 LLVM_ATTRIBUTE_USED void linkComponents() {
   errs() << (void *)&llvm_orc_registerEHFrameSectionWrapper
          << (void *)&llvm_orc_deregisterEHFrameSectionWrapper
-         << (void *)&llvm_orc_registerJITLoaderGDBWrapper;
+         << (void *)&llvm_orc_registerJITLoaderGDBWrapper
+         << (void *)&llvm_orc_registerJITLoaderGDBAllocAction;
 }
 
 void printErrorAndExit(Twine ErrMsg) {

tools/llvm-jitlink/llvm-jitlink.cpp

diff --git a/tools/llvm-jitlink/llvm-jitlink.cpp b/tools/llvm-jitlink/llvm-jitlink.cpp
index 624dcea..fc2bf0d 100644
--- a/tools/llvm-jitlink/llvm-jitlink.cpp
+++ b/tools/llvm-jitlink/llvm-jitlink.cpp
@@ -239,7 +239,8 @@
 static LLVM_ATTRIBUTE_USED void linkComponents() {
   errs() << (void *)&llvm_orc_registerEHFrameSectionWrapper
          << (void *)&llvm_orc_deregisterEHFrameSectionWrapper
-         << (void *)&llvm_orc_registerJITLoaderGDBWrapper;
+         << (void *)&llvm_orc_registerJITLoaderGDBWrapper
+         << (void *)&llvm_orc_registerJITLoaderGDBAllocAction;
 }
 
 static bool UseTestResultOverride = false;