commit 1004a6028e45552321585fed387cf220266a6c7a
author Craig Topper <craig.topper@sifive.com> Fri Apr 16 13:16:47 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Sat Apr 17 21:27:18 2021 -0700
tree 8330a02d01176f5e90aa0647073dbee0f1f8390f
parent 85ca1d13dd0025e9e6d7bc806401d480dbd2bd2e

[TableGen] Predicate::operator== needs to compare the HwMode feature name in addition to the HwMode flag.

This was causing GenerateVariants to lose some variants since
HwMode is expanded first. We were mistakenly thinking the HwMode
predicate matched and finding the variant was isomorphic to a
pattern in another HwMode and discarding it.

Found while investigating it if would be better to generate
variants before expanding HwModes to improve RISCV build time.
I noticed an increase in the number of Opc_MorphNodeTo in the table
which indicated that the number of patterns had changed.

GitOrigin-RevId: 6b446310bef95eecea7afdd989e57e64d39a3b0d

utils/TableGen/CodeGenDAGPatterns.h

diff --git a/utils/TableGen/CodeGenDAGPatterns.h b/utils/TableGen/CodeGenDAGPatterns.h
index d0cf18b..20b27bc 100644
--- a/utils/TableGen/CodeGenDAGPatterns.h
+++ b/utils/TableGen/CodeGenDAGPatterns.h
@@ -1078,7 +1078,8 @@
   }
 
   bool operator==(const Predicate &P) const {
-    return IfCond == P.IfCond && IsHwMode == P.IsHwMode && Def == P.Def;
+    return IfCond == P.IfCond && IsHwMode == P.IsHwMode && Def == P.Def &&
+           Features == P.Features;
   }
   bool operator<(const Predicate &P) const {
     if (IsHwMode != P.IsHwMode)