commit 944fb893489de116d8c97567378823e4968d0664
author Pavel Labath <labath@google.com> Mon Jun 18 16:10:20 2018 +0000
committer Pavel Labath <labath@google.com> Mon Jun 18 16:10:20 2018 +0000
tree d543bba7d257d93b261a682b934d391756cd2810
parent 435bdedea1ac281f505fed1c2d81dfc99b4aafaa

Fix macosx build broken by the VersionTuple refactor

I actually did check that macos builds before committing, but this error
was in conditionally compiled code that did not seem to be used on my
machine.

I also fix a typo in the previous speculative NetBSD patch.

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@334955 91177308-0d34-0410-b5e6-96231b3b80d8

source/Host/macosx/objcxx/Host.mm

diff --git a/source/Host/macosx/objcxx/Host.mm b/source/Host/macosx/objcxx/Host.mm
index c8d441b..504ed10 100644
--- a/source/Host/macosx/objcxx/Host.mm
+++ b/source/Host/macosx/objcxx/Host.mm
@@ -851,14 +851,11 @@
   if (g_use_close_on_exec_flag == eLazyBoolCalculate) {
     g_use_close_on_exec_flag = eLazyBoolNo;
 
-    uint32_t major, minor, update;
-    if (HostInfo::GetOSVersion(major, minor, update)) {
+    llvm::VersionTuple version = HostInfo::GetOSVersion();
+    if (version > llvm::VersionTuple(10, 7)) {
       // Kernel panic if we use the POSIX_SPAWN_CLOEXEC_DEFAULT on 10.7 or
       // earlier
-      if (major > 10 || (major == 10 && minor > 7)) {
-        // Only enable for 10.8 and later OS versions
-        g_use_close_on_exec_flag = eLazyBoolYes;
-      }
+      g_use_close_on_exec_flag = eLazyBoolYes;
     }
   }
 #else

source/Host/netbsd/HostInfoNetBSD.cpp

diff --git a/source/Host/netbsd/HostInfoNetBSD.cpp b/source/Host/netbsd/HostInfoNetBSD.cpp
index ff0cec7..dfbce31 100644
--- a/source/Host/netbsd/HostInfoNetBSD.cpp
+++ b/source/Host/netbsd/HostInfoNetBSD.cpp
@@ -26,7 +26,7 @@
 
   ::memset(&un, 0, sizeof(un));
   if (::uname(&un) < 0)
-    return VersionTuple();
+    return llvm::VersionTuple();
 
   /* Accept versions like 7.99.21 and 6.1_STABLE */
   uint32_t major, minor, update;