commit cd3f90931a86d9047cee3cd17b33393f6b048b6b
author James Henderson <jh7370@my.bristol.ac.uk> Tue Oct 30 10:55:14 2018 +0000
committer James Henderson <jh7370@my.bristol.ac.uk> Tue Oct 30 10:55:14 2018 +0000
tree a7c7bb87648036a86bfbfe1a7dd906d895c1889b
parent 6ee254669081fa0cd2c0cb4d9dade5df9a2ad46f

[ELF][PPC64]Workaround bogus Visual Studio build warning

Visual Studio has a bug where it converts the integer literal 2147483648
into an unsigned int instead of a long long (i.e. it follows C89 rules).
The bug has been reported as:
https://developercommunity.visualstudio.com/content/problem/141813/-2147483648-c4146-error.html.

Because of this bug, we were getting a signed/unsigned comparison
warning in VS2015 from the old code (the subsequent unary negation had
no effect on the type).

Reviewed by: sfertile

Differential Revision: https://reviews.llvm.org/D53821


git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@345579 91177308-0d34-0410-b5e6-96231b3b80d8

ELF/Arch/PPC64.cpp

diff --git a/ELF/Arch/PPC64.cpp b/ELF/Arch/PPC64.cpp
index 3c511e1..a12d714 100644
--- a/ELF/Arch/PPC64.cpp
+++ b/ELF/Arch/PPC64.cpp
@@ -849,7 +849,8 @@
   int32_t StackFrameSize = (HiImm * 65536) + LoImm;
   // Check that the adjusted size doesn't overflow what we can represent with 2
   // instructions.
-  if (StackFrameSize < -2147483648 + Config->SplitStackAdjustSize) {
+  if (StackFrameSize <
+      std::numeric_limits<int32_t>::min() + Config->SplitStackAdjustSize) {
     error(getErrorLocation(Loc) + "split-stack prologue adjustment overflows");
     return false;
   }