commit addb7136b97db6bb7bb4da031835b1a2a3ede186
author Rui Ueyama <ruiu@google.com> Thu Oct 11 20:43:01 2018 +0000
committer Rui Ueyama <ruiu@google.com> Thu Oct 11 20:43:01 2018 +0000
tree 61177e70bb184d65105a2d68b5d1dce821578997
parent 529fbcdeabce8468e8fadbdddb9cfaaf9d724edd

Rename SymbolTable::addRegular -> SymbolTable::addDefined.

We have addAbsolute, addBitcode, addCommon, etc. addRegular looked a
bit inconsistent.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@344294 91177308-0d34-0410-b5e6-96231b3b80d8

ELF/InputFiles.cpp

diff --git a/ELF/InputFiles.cpp b/ELF/InputFiles.cpp
index 3980403..c82bef5 100644
--- a/ELF/InputFiles.cpp
+++ b/ELF/InputFiles.cpp
@@ -813,7 +813,7 @@
     if (Sec == &InputSection::Discarded)
       return Symtab->addUndefined<ELFT>(Name, Binding, StOther, Type,
                                         /*CanOmitFromDynSym=*/false, this);
-    return Symtab->addRegular(Name, StOther, Type, Value, Size, Binding, Sec,
+    return Symtab->addDefined(Name, StOther, Type, Value, Size, Binding, Sec,
                               this);
   }
 }
@@ -1202,11 +1202,11 @@
     if (!isAlnum(S[I]))
       S[I] = '_';
 
-  Symtab->addRegular(Saver.save(S + "_start"), STV_DEFAULT, STT_OBJECT, 0, 0,
+  Symtab->addDefined(Saver.save(S + "_start"), STV_DEFAULT, STT_OBJECT, 0, 0,
                      STB_GLOBAL, Section, nullptr);
-  Symtab->addRegular(Saver.save(S + "_end"), STV_DEFAULT, STT_OBJECT,
+  Symtab->addDefined(Saver.save(S + "_end"), STV_DEFAULT, STT_OBJECT,
                      Data.size(), 0, STB_GLOBAL, Section, nullptr);
-  Symtab->addRegular(Saver.save(S + "_size"), STV_DEFAULT, STT_OBJECT,
+  Symtab->addDefined(Saver.save(S + "_size"), STV_DEFAULT, STT_OBJECT,
                      Data.size(), 0, STB_GLOBAL, nullptr, nullptr);
 }
 

ELF/SymbolTable.cpp

diff --git a/ELF/SymbolTable.cpp b/ELF/SymbolTable.cpp
index 1e8eba0..9bf0ad3 100644
--- a/ELF/SymbolTable.cpp
+++ b/ELF/SymbolTable.cpp
@@ -142,7 +142,7 @@
 Defined *SymbolTable::addAbsolute(StringRef Name, uint8_t Visibility,
                                   uint8_t Binding) {
   Symbol *Sym =
-      addRegular(Name, Visibility, STT_NOTYPE, 0, 0, Binding, nullptr, nullptr);
+      addDefined(Name, Visibility, STT_NOTYPE, 0, 0, Binding, nullptr, nullptr);
   return cast<Defined>(Sym);
 }
 
@@ -471,7 +471,7 @@
   error(Msg);
 }
 
-Symbol *SymbolTable::addRegular(StringRef Name, uint8_t StOther, uint8_t Type,
+Symbol *SymbolTable::addDefined(StringRef Name, uint8_t StOther, uint8_t Type,
                                 uint64_t Value, uint64_t Size, uint8_t Binding,
                                 SectionBase *Section, InputFile *File) {
   Symbol *S;

ELF/SymbolTable.h

diff --git a/ELF/SymbolTable.h b/ELF/SymbolTable.h
index 567d12f..69d923e 100644
--- a/ELF/SymbolTable.h
+++ b/ELF/SymbolTable.h
@@ -47,7 +47,7 @@
   Symbol *addUndefined(StringRef Name, uint8_t Binding, uint8_t StOther,
                        uint8_t Type, bool CanOmitFromDynSym, InputFile *File);
 
-  Symbol *addRegular(StringRef Name, uint8_t StOther, uint8_t Type,
+  Symbol *addDefined(StringRef Name, uint8_t StOther, uint8_t Type,
                      uint64_t Value, uint64_t Size, uint8_t Binding,
                      SectionBase *Section, InputFile *File);
 

ELF/Writer.cpp

diff --git a/ELF/Writer.cpp b/ELF/Writer.cpp
index 6f652ac..ac34970 100644
--- a/ELF/Writer.cpp
+++ b/ELF/Writer.cpp
@@ -170,7 +170,7 @@
   Symbol *S = Symtab->find(Name);
   if (!S || S->isDefined())
     return nullptr;
-  Symbol *Sym = Symtab->addRegular(Name, StOther, STT_NOTYPE, Val,
+  Symbol *Sym = Symtab->addDefined(Name, StOther, STT_NOTYPE, Val,
                                    /*Size=*/0, Binding, Sec,
                                    /*File=*/nullptr);
   return cast<Defined>(Sym);
@@ -1550,7 +1550,7 @@
   // Even the author of gold doesn't remember why gold behaves that way.
   // https://sourceware.org/ml/binutils/2002-03/msg00360.html
   if (In.DynSymTab)
-    Symtab->addRegular("_DYNAMIC", STV_HIDDEN, STT_NOTYPE, 0 /*Value*/,
+    Symtab->addDefined("_DYNAMIC", STV_HIDDEN, STT_NOTYPE, 0 /*Value*/,
                        /*Size=*/0, STB_WEAK, In.Dynamic,
                        /*File=*/nullptr);