[clangd] Ignore implicit conversion-operator nodes in find refs.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66478
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@369514 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/clangd/XRefs.cpp b/clangd/XRefs.cpp
index 5dd5186..829fdf4 100644
--- a/clangd/XRefs.cpp
+++ b/clangd/XRefs.cpp
@@ -187,6 +187,11 @@
// experssion is impossible to write down.
if (const auto *CtorExpr = dyn_cast<CXXConstructExpr>(E))
return CtorExpr->getParenOrBraceRange().isInvalid();
+ // Ignore implicit conversion-operator AST node.
+ if (const auto *ME = dyn_cast<MemberExpr>(E)) {
+ if (isa<CXXConversionDecl>(ME->getMemberDecl()))
+ return ME->getMemberLoc().isInvalid();
+ }
return isa<ImplicitCastExpr>(E);
};
diff --git a/clangd/unittests/XRefsTests.cpp b/clangd/unittests/XRefsTests.cpp
index 1079eea..877bfaa 100644
--- a/clangd/unittests/XRefsTests.cpp
+++ b/clangd/unittests/XRefsTests.cpp
@@ -2069,6 +2069,18 @@
using ::[[fo^o]];
}
)cpp",
+
+ R"cpp(
+ struct X {
+ operator bool();
+ };
+
+ int test() {
+ X [[a]];
+ [[a]].operator bool();
+ if ([[a^]]) {} // ignore implicit conversion-operator AST node
+ }
+ )cpp",
};
for (const char *Test : Tests) {
Annotations T(Test);
