commit 464620736596226ba4f9a0d232cd28f9661aa4ff
author Haojian Wu <hokein@google.com> Fri Dec 14 13:19:38 2018 +0000
committer Haojian Wu <hokein@google.com> Fri Dec 14 13:19:38 2018 +0000
tree 8e13485e5ba6611cfb2edb79788af1e9727b2661
parent 05df5fd1cd02e3a830a2c3d545066e4a3a4fdbee

[clangd] Fix memory leak in ClangdTests.

Summary:
createInvocationFromCommandLine sets DisableFree to true by default,
which leads memory leak in clangd. The fix is to  use the `BuildCompilationInvocation`
to create CI with the correct options (DisableFree is false).

Fix https://bugs.llvm.org/show_bug.cgi?id=39991.

Reviewers: kadircet

Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits

Differential Revision: https://reviews.llvm.org/D55702

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@349145 91177308-0d34-0410-b5e6-96231b3b80d8

unittests/clangd/TestTU.cpp

diff --git a/unittests/clangd/TestTU.cpp b/unittests/clangd/TestTU.cpp
index e8fb63c..4e14262 100644
--- a/unittests/clangd/TestTU.cpp
+++ b/unittests/clangd/TestTU.cpp
@@ -38,8 +38,10 @@
   Inputs.Contents = Code;
   Inputs.FS = buildTestFS({{FullFilename, Code}, {FullHeaderName, HeaderCode}});
   auto PCHs = std::make_shared<PCHContainerOperations>();
+  auto CI = buildCompilerInvocation(Inputs);
+  assert(CI && "Failed to build compilation invocation.");
   auto Preamble =
-      buildPreamble(FullFilename, *createInvocationFromCommandLine(Cmd),
+      buildPreamble(FullFilename, *CI,
                     /*OldPreamble=*/nullptr,
                     /*OldCompileCommand=*/Inputs.CompileCommand, Inputs, PCHs,
                     /*StoreInMemory=*/true, /*PreambleCallback=*/nullptr);