commit 3548ba485031fb459736c576db3dc8d3ad6cf74f
author Kadir Cetinkaya <kadircet@google.com> Mon Feb 11 13:03:08 2019 +0000
committer Kadir Cetinkaya <kadircet@google.com> Mon Feb 11 13:03:08 2019 +0000
tree d4d9274c9fb1e25690ce8f70971877d22392c905
parent 4d6befeeec52104e9c77800b91786bd47a5323bf

[clangd] Index parameters in function decls

Reviewers: hokein

Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57950

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@353696 91177308-0d34-0410-b5e6-96231b3b80d8

clangd/XRefs.cpp

diff --git a/clangd/XRefs.cpp b/clangd/XRefs.cpp
index 74ededc..3f89165 100644
--- a/clangd/XRefs.cpp
+++ b/clangd/XRefs.cpp
@@ -215,6 +215,7 @@
   IndexOpts.SystemSymbolFilter =
       index::IndexingOptions::SystemSymbolFilterKind::All;
   IndexOpts.IndexFunctionLocals = true;
+  IndexOpts.IndexParametersInDeclarations = true;
   indexTopLevelDecls(AST.getASTContext(), AST.getPreprocessor(),
                      AST.getLocalTopLevelDecls(), DeclMacrosFinder, IndexOpts);
 
@@ -400,6 +401,7 @@
   IndexOpts.SystemSymbolFilter =
       index::IndexingOptions::SystemSymbolFilterKind::All;
   IndexOpts.IndexFunctionLocals = true;
+  IndexOpts.IndexParametersInDeclarations = true;
   indexTopLevelDecls(AST.getASTContext(), AST.getPreprocessor(),
                      AST.getLocalTopLevelDecls(), RefFinder, IndexOpts);
   return std::move(RefFinder).take();

unittests/clangd/SymbolInfoTests.cpp

diff --git a/unittests/clangd/SymbolInfoTests.cpp b/unittests/clangd/SymbolInfoTests.cpp
index 69a27f2..ed34c03 100644
--- a/unittests/clangd/SymbolInfoTests.cpp
+++ b/unittests/clangd/SymbolInfoTests.cpp
@@ -302,6 +302,12 @@
         )cpp",
               {CreateExpectedSymbolDetails("bar", "foo::", "c:@E@foo@bar")}},
           {
+              R"cpp( // Parameters in declarations
+          void foo(int ba^r);
+        )cpp",
+              {CreateExpectedSymbolDetails("bar", "foo",
+                                           "c:TestTU.cpp@50@F@foo#I#@bar")}},
+          {
               R"cpp( // Type inferrence with auto keyword
           struct foo {};
           foo getfoo() { return foo{}; }

unittests/clangd/XRefsTests.cpp

diff --git a/unittests/clangd/XRefsTests.cpp b/unittests/clangd/XRefsTests.cpp
index e68790a..acbeaf4 100644
--- a/unittests/clangd/XRefsTests.cpp
+++ b/unittests/clangd/XRefsTests.cpp
@@ -86,6 +86,10 @@
           auto *X = &[[foo]];
         }
       )cpp",
+
+      R"cpp(// Function parameter in decl
+        void foo(int [[^bar]]);
+      )cpp",
   };
   for (const char *Test : Tests) {
     Annotations T(Test);