commit 5c0be437a68723cf4a0e15e78bdd1bd1970166c5
author Kostya Kortchinsky <kostyak@google.com> Mon Sep 21 14:09:37 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 23 19:34:25 2020 -0700
tree 578c440cfb8fa38833a46acc45c9d16536eb0ad2
parent bedb1af2e629c04f74051fba12755f3ab742b500

[scudo][standalone] Remove the pthread key from the shared TSD

https://reviews.llvm.org/D87420 removed the uses of the pthread key,
but the key itself was left in the shared TSD registry. It is created
on registry initialization, and destroyed on registry teardown.

There is really no use for it now, so we can just remove it.

Differential Revision: https://reviews.llvm.org/D88046

GitOrigin-RevId: 7b51961cd0748ed5bd3b6fdacbfe596c374c93bc

tsd_shared.h

diff --git a/tsd_shared.h b/tsd_shared.h
index 2cacfde..6a68b3e 100644
--- a/tsd_shared.h
+++ b/tsd_shared.h
@@ -26,7 +26,6 @@
 struct TSDRegistrySharedT {
   void initLinkerInitialized(Allocator *Instance) {
     Instance->initLinkerInitialized();
-    CHECK_EQ(pthread_key_create(&PThreadKey, nullptr), 0); // For non-TLS
     for (u32 I = 0; I < TSDsArraySize; I++)
       TSDs[I].initLinkerInitialized(Instance);
     const u32 NumberOfCPUs = getNumberOfCPUs();
@@ -39,10 +38,7 @@
     initLinkerInitialized(Instance);
   }
 
-  void unmapTestOnly() {
-    setCurrentTSD(nullptr);
-    pthread_key_delete(PThreadKey);
-  }
+  void unmapTestOnly() { setCurrentTSD(nullptr); }
 
   ALWAYS_INLINE void initThreadMaybe(Allocator *Instance,
                                      UNUSED bool MinimalInit) {
@@ -201,7 +197,6 @@
     return CurrentTSD;
   }
 
-  pthread_key_t PThreadKey;
   atomic_u32 CurrentIndex;
   u32 NumberOfTSDs;
   u32 NumberOfCoPrimes;