commit 327b61f1a41274e424fb1d27e4bbb0aba50c575b
author Kostya Kortchinsky <kostyak@google.com> Wed Dec 02 15:19:42 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Dec 08 19:22:35 2020 -0800
tree 256d63d5843dc7582d7c751b876fb57ec35bb13c
parent 79b705de758b7c866d22571ade1ad6e962268cbb

 [scudo][standalone] Add missing va_end() in ScopedString::append

In ScopedString::append va_list ArgsCopy is created but never cleanuped
which can lead to undefined behaviour, like stack corruption.

Reviewed By: cryptoad

Differential Revision: https://reviews.llvm.org/D92383

GitOrigin-RevId: 0a09c1cc9dcbec8126344123e9481bed6524e5ec

string_utils.cpp

diff --git a/string_utils.cpp b/string_utils.cpp
index 7578123..f304491 100644
--- a/string_utils.cpp
+++ b/string_utils.cpp
@@ -222,6 +222,7 @@
       static_cast<uptr>(formatString(C, sizeof(C), Format, Args)) + 1;
   String.resize(Length + AdditionalLength);
   formatString(String.data() + Length, AdditionalLength, Format, ArgsCopy);
+  va_end(ArgsCopy);
   Length = strlen(String.data());
   CHECK_LT(Length, String.size());
 }