commit d8f048261baaa7a1fab904a576492a58d964d1a4
author Nikita Popov <nikita.ppv@gmail.com> Wed Sep 15 23:01:01 2021 +0200
committer Copybara-Service <copybara-worker@google.com> Thu Sep 16 12:10:24 2021 -0700
tree 0449b05820e732489e756e331e5d421fbfea1472
parent d55ab4ebaa7cf49995880bf3ff20040fe5449f27

[IR] Return AAMDNodes from Instruction::getMetadata() (NFC)

getMetadata() currently uses a weird API where it populates a
structure passed to it, and optionally merges into it. Instead,
we can return the AAMDNodes and provide a separate merge() API.
This makes usages more compact.

Differential Revision: https://reviews.llvm.org/D109852

GitOrigin-RevId: 0fc624f029f568e91caf74d90abc5d8d971151c2

lib/Analysis/ScopDetection.cpp

diff --git a/lib/Analysis/ScopDetection.cpp b/lib/Analysis/ScopDetection.cpp
index 35a69b1..a4a5224 100644
--- a/lib/Analysis/ScopDetection.cpp
+++ b/lib/Analysis/ScopDetection.cpp
@@ -1147,8 +1147,7 @@
 
   // Check if the base pointer of the memory access does alias with
   // any other pointer. This cannot be handled at the moment.
-  AAMDNodes AATags;
-  Inst->getAAMetadata(AATags);
+  AAMDNodes AATags = Inst->getAAMetadata();
   AliasSet &AS = Context.AST.getAliasSetFor(
       MemoryLocation::getBeforeOrAfter(BP->getValue(), AATags));