commit 39f49378242ac0800bb3270aea1ea302d1568f69
author Logan Smith <logan.r.smith0@gmail.com> Wed Jul 22 14:16:35 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 01 01:06:01 2020 -0700
tree 2cbb046695310f5b6866013256c8440b171e9ea2
parent 5df5f05ce87127cbed222cb52a51d0378914c4c8

Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories.

Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds.

GitOrigin-RevId: 388c9fb1af48b059d8b65cb2e002e0992d147aa5

acxxel/CMakeLists.txt

diff --git a/acxxel/CMakeLists.txt b/acxxel/CMakeLists.txt
index 7e71446..6391c73 100644
--- a/acxxel/CMakeLists.txt
+++ b/acxxel/CMakeLists.txt
@@ -36,6 +36,9 @@
 
 # Add warning flags.
 set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+if (CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
+    add_compile_options("-Wno-suggest-override")
+endif()
 
 add_library(
     acxxel