commit 2dcf5b91e8c5d95824c1fdf6419a75555d1dca87
author Joseph Huber <huberjn@outlook.com> Wed Jan 10 11:42:04 2024 -0600
committer Copybara-Service <copybara-worker@google.com> Wed Jan 10 09:59:28 2024 -0800
tree f31a2d876e55fcdd4dd06b2a38775cf981a751ce
parent dd09333b4efa40d1b5cd7fb2a99f7cb518275c67

[Libomptarget] Do not abort on failed plugin init (#77623)

Summary:
The current code logic is supposed to skip plugins that aren't found or
could not be loaded. However, the plugic ontained a call to `abort` if
it failed, which prevented us from continuing if initilalization the
plugin failed (such as if `dlopen` failed for the dyanmic plugins).
GitOrigin-RevId: e203968e411bba6395133d93881eb32e7895e50b

libomptarget/plugins-nextgen/common/src/PluginInterface.cpp

diff --git a/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp b/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp
index 0db7910..1bd70b8 100644
--- a/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp
+++ b/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp
@@ -1662,8 +1662,8 @@
 int32_t __tgt_rtl_init_plugin() {
   auto Err = Plugin::initIfNeeded();
   if (Err) {
-    REPORT("Failure to initialize plugin " GETNAME(TARGET_NAME) ": %s\n",
-           toString(std::move(Err)).data());
+    [[maybe_unused]] std::string ErrStr = toString(std::move(Err));
+    DP("Failed to init plugin: %s", ErrStr.c_str());
     return OFFLOAD_FAIL;
   }