commit 381bd1ed202a329ebc65134b6f41eb2b49c21698
author Chia-hung Duan <chiahungduan@google.com> Sat Nov 27 22:36:42 2021 +0000
committer Copybara-Service <copybara-worker@google.com> Sat Nov 27 15:07:34 2021 -0800
tree 75bb3450059489d65c5c18a94b2137776118272b
parent 5f36c044300931e700daf3b357ed44888d022079

[mlir] Enable MLIRDialectUtilsTests

Also remove `TooFewDims` test which tried to create an invalid AffineMap.
The creation of an invalid AffineMap is rejected by `willBeValidAffineMap`,
as a result we can deprecate the test.

Reviewed By: bondhugula

Differential Revision: https://reviews.llvm.org/D114657

GitOrigin-RevId: 2afd16fe725ffa98723abda6dc19ee6d70f60a4d

unittests/Dialect/CMakeLists.txt

diff --git a/unittests/Dialect/CMakeLists.txt b/unittests/Dialect/CMakeLists.txt
index 6b44156..f37f578 100644
--- a/unittests/Dialect/CMakeLists.txt
+++ b/unittests/Dialect/CMakeLists.txt
@@ -9,3 +9,4 @@
 add_subdirectory(Quant)
 add_subdirectory(SparseTensor)
 add_subdirectory(SPIRV)
+add_subdirectory(Utils)

unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp

diff --git a/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp b/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp
index bb95402..583dbd4 100644
--- a/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp
+++ b/unittests/Dialect/Utils/StructuredOpsUtilsTest.cpp
@@ -110,19 +110,6 @@
   EXPECT_THAT(maps, Not(Truly(isRowMajorMatmul)));
 }
 
-TEST(isRowMajorMatmul, TooFewDims) {
-  MLIRContext context;
-
-  AffineExpr m, n, k;
-  bindDims(&context, m, n, k);
-  auto mapA = AffineMapAttr::get(AffineMap::get(3, 0, {m, k}, &context));
-  auto mapB = AffineMapAttr::get(AffineMap::get(2, 0, {k, n}, &context));
-  auto mapC = AffineMapAttr::get(AffineMap::get(3, 0, {m, n}, &context));
-  auto maps = ArrayAttr::get(&context, {mapA, mapB, mapC});
-
-  EXPECT_THAT(maps, Not(Truly(isRowMajorMatmul)));
-}
-
 TEST(isRowMajorMatmul, TooFewOutputs) {
   MLIRContext context;