commit cecaefaa68ce93d18cc2344e2cc134f53d464754
author Hans Wennborg <hans@hanshq.net> Mon May 04 18:00:13 2015 +0000
committer Copybara-Service <copybara-worker@google.com> Mon Oct 05 13:48:40 2020 -0700
tree 7f34df152c3ea1aebbc5082ce0965c3c7b01be4c
parent 0c9eaa932d2acaab88818c35d9d197e7fec3baf5

Option parsing: properly handle flag aliases for joined options (PR23394)

A joined option always needs to have an argument, even if it's an empty one.

Clang would previously assert when trying to use --extra-warnings, which is
a flag alias for -W, which is a joined option.

llvm-svn: 236434
GitOrigin-RevId: 8d8146fa73fcb7bd75c976605b395605d685bbc5

unittests/Option/Opts.td

diff --git a/unittests/Option/Opts.td b/unittests/Option/Opts.td
index aaed6b2..c96774a 100644
--- a/unittests/Option/Opts.td
+++ b/unittests/Option/Opts.td
@@ -23,4 +23,6 @@
 def J : Flag<["-"], "J">, Alias<B>, AliasArgs<["foo"]>;
 def Joo : Flag<["-"], "Joo">, Alias<B>, AliasArgs<["bar"]>;
 
+def K : Flag<["-"], "K">, Alias<B>;
+
 def Slurp : Option<["-"], "slurp", KIND_REMAINING_ARGS>;