| commit | b5343943690931159df384c7476b99ca1b9d756d | [log] [tgz] |
|---|---|---|
| author | Logan Smith <logan.r.smith0@gmail.com> | Wed Jul 22 14:16:35 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Oct 27 06:29:00 2020 -0700 |
| tree | 1777ca73ed413f079c68a052a0885e3ab66e2c18 | |
| parent | 4063e867c3a9c70e7bb847828ca6cdb4e56336e8 [diff] |
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds. GitOrigin-RevId: 388c9fb1af48b059d8b65cb2e002e0992d147aa5