commit c0af7e672c2d5e6c19efddbcb1460c55b51efe60
author Abhina Sreeskantharajan <Abhina.Sreeskantharajan@ibm.com> Thu Mar 25 09:47:25 2021 -0400
committer Copybara-Service <copybara-worker@google.com> Thu Mar 25 13:39:47 2021 -0700
tree 0d726950aed459dd23ea4e3b465941a45cc5f2b7
parent 1f7d1e6a4551657914cb56628e994c9288c59dcc

[NFC] Reordering parameters in getFile and getFileOrSTDIN

In future patches I will be setting the IsText parameter frequently so I will refactor the args to be in the following order. I have removed the FileSize parameter because it is never used.

```
  static ErrorOr<std::unique_ptr<MemoryBuffer>>
  getFile(const Twine &Filename, bool IsText = false,
          bool RequiresNullTerminator = true, bool IsVolatile = false);

  static ErrorOr<std::unique_ptr<MemoryBuffer>>
  getFileOrSTDIN(const Twine &Filename, bool IsText = false,
                 bool RequiresNullTerminator = true);

 static ErrorOr<std::unique_ptr<MB>>
 getFileAux(const Twine &Filename, uint64_t MapSize, uint64_t Offset,
            bool IsText, bool RequiresNullTerminator, bool IsVolatile);

  static ErrorOr<std::unique_ptr<WritableMemoryBuffer>>
  getFile(const Twine &Filename, bool IsVolatile = false);
```

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D99182

GitOrigin-RevId: c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6

source/Host/common/FileSystem.cpp

diff --git a/source/Host/common/FileSystem.cpp b/source/Host/common/FileSystem.cpp
index 64ecf27..9076188 100644
--- a/source/Host/common/FileSystem.cpp
+++ b/source/Host/common/FileSystem.cpp
@@ -307,7 +307,7 @@
   std::unique_ptr<llvm::WritableMemoryBuffer> buffer;
   if (size == 0) {
     auto buffer_or_error =
-        llvm::WritableMemoryBuffer::getFile(*external_path, -1, is_volatile);
+        llvm::WritableMemoryBuffer::getFile(*external_path, is_volatile);
     if (!buffer_or_error)
       return nullptr;
     buffer = std::move(*buffer_or_error);

source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp

diff --git a/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp b/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp
index 35a823e..cb7bbee 100644
--- a/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp
+++ b/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp
@@ -173,7 +173,7 @@
   if (ec || magic != llvm::file_magic::pdb)
     return nullptr;
   llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> ErrorOrBuffer =
-      llvm::MemoryBuffer::getFile(PdbPath, /*FileSize=*/-1,
+      llvm::MemoryBuffer::getFile(PdbPath, /*IsText=*/false,
                                   /*RequiresNullTerminator=*/false);
   if (!ErrorOrBuffer)
     return nullptr;

unittests/TestingSupport/TestUtilities.cpp

diff --git a/unittests/TestingSupport/TestUtilities.cpp b/unittests/TestingSupport/TestUtilities.cpp
index 34f49e5..86f3d1a 100644
--- a/unittests/TestingSupport/TestUtilities.cpp
+++ b/unittests/TestingSupport/TestUtilities.cpp
@@ -38,8 +38,8 @@
 
 llvm::Expected<TestFile> TestFile::fromYamlFile(const llvm::Twine &Name) {
   auto BufferOrError =
-      llvm::MemoryBuffer::getFile(GetInputFilePath(Name), /*FileSize*/ -1,
-                                  /*RequiresNullTerminator*/ false);
+      llvm::MemoryBuffer::getFile(GetInputFilePath(Name), /*IsText=*/false,
+                                  /*RequiresNullTerminator=*/false);
   if (!BufferOrError)
     return llvm::errorCodeToError(BufferOrError.getError());
   return fromYaml(BufferOrError.get()->getBuffer());