commit 6a9a65af7daec1283c4394fa075502049bb753c0
author Michael Buch <michaelbuch12@gmail.com> Mon Apr 15 21:45:41 2024 +0100
committer Copybara-Service <copybara-worker@google.com> Mon Apr 15 13:51:59 2024 -0700
tree 512430004a877891fb5186c0abea51c8e756ed5d
parent c5a5420d49b597b8fbeb58327c71b88b3a1f776a

[lldb][ClangExpressionDeclMap][NFC] Remove unused NameSearchContext::m_found_function (#88724)

This member was never actually used, ever since its introduction in
`ca4e0fd7e63b90e6f68044af47248c64f250ee8f`.

GitOrigin-RevId: 905d2ecbb63f4087b50d633b012c9915ab3a6829

source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

diff --git a/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp b/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
index 2d306b4..31f6447 100644
--- a/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
+++ b/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
@@ -1049,7 +1049,6 @@
     context.AddNamedDecl(copied_function);
 
     context.m_found_function_with_type_info = true;
-    context.m_found_function = true;
   } else if (auto copied_var = dyn_cast<clang::VarDecl>(copied_decl)) {
     context.AddNamedDecl(copied_var);
     context.m_found_variable = true;
@@ -1299,7 +1298,6 @@
 
         AddOneFunction(context, sym_ctx.function, nullptr);
         context.m_found_function_with_type_info = true;
-        context.m_found_function = true;
       } else if (sym_ctx.symbol) {
         Symbol *symbol = sym_ctx.symbol;
         if (target && symbol->GetType() == eSymbolTypeReExported) {
@@ -1331,10 +1329,8 @@
     if (!context.m_found_function_with_type_info) {
       if (extern_symbol) {
         AddOneFunction(context, nullptr, extern_symbol);
-        context.m_found_function = true;
       } else if (non_extern_symbol) {
         AddOneFunction(context, nullptr, non_extern_symbol);
-        context.m_found_function = true;
       }
     }
   }

source/Plugins/ExpressionParser/Clang/NameSearchContext.h

diff --git a/source/Plugins/ExpressionParser/Clang/NameSearchContext.h b/source/Plugins/ExpressionParser/Clang/NameSearchContext.h
index dc8621d..9a33206 100644
--- a/source/Plugins/ExpressionParser/Clang/NameSearchContext.h
+++ b/source/Plugins/ExpressionParser/Clang/NameSearchContext.h
@@ -41,7 +41,6 @@
 
   bool m_found_variable = false;
   bool m_found_function_with_type_info = false;
-  bool m_found_function = false;
   bool m_found_local_vars_nsp = false;
   bool m_found_type = false;