commit f4599a1ba74bfd75b6ae4834b6d2ab3bac2dc519
author Fangrui Song <i@maskray.me> Mon Feb 12 17:37:29 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Feb 12 17:54:25 2024 -0800
tree c7140d929a8ede194c32f9220654b6db73b10988
parent db481f94fd548eb8c9c104effe3cc96aa8da6dc1

[ELF] Properly reject unsupported e_machine

Fix an incorrect llvm_unreachable.

GitOrigin-RevId: f7c2c32c019275e88fd14e401aaa68b760f32a28

ELF/Target.cpp

diff --git a/ELF/Target.cpp b/ELF/Target.cpp
index 671d22c..286db1e 100644
--- a/ELF/Target.cpp
+++ b/ELF/Target.cpp
@@ -89,8 +89,9 @@
     return getSPARCV9TargetInfo();
   case EM_X86_64:
     return getX86_64TargetInfo();
+  default:
+    fatal("unsupported e_machine value: " + Twine(config->emachine));
   }
-  llvm_unreachable("unknown target machine");
 }
 
 ErrorPlace elf::getErrorPlace(const uint8_t *loc) {

test/ELF/unsupported-emachine.test

diff --git a/test/ELF/unsupported-emachine.test b/test/ELF/unsupported-emachine.test
new file mode 100644
index 0000000..43d907e
--- /dev/null
+++ b/test/ELF/unsupported-emachine.test
@@ -0,0 +1,11 @@
+# RUN: yaml2obj %s -o %t.o
+# RUN: not ld.lld %t.o -o /dev/null 2>&1 | FileCheck %s
+
+# CHECK: error: unsupported e_machine value: 9
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_S370