commit f2ec6ab974ac2fcee14da281da427791e9a1ef93
author Fangrui Song <i@maskray.me> Sun Nov 28 13:44:41 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Sun Nov 28 13:46:01 2021 -0800
tree 53e51337a459b0c616450ab977d44713ccdabb40
parent 2ae727405f528717d7db010be684af5ef6aff755

[ELF] Simplify assignFileOffsets

There is a difference with non-SHF_ALLOC SHT_NOBITS when off%sh_addralign!=0
which doesn't happen/matter in practice.

GitOrigin-RevId: cecc6893a08618fc753cd55893b720a01fbd2b51

ELF/Writer.cpp

diff --git a/ELF/Writer.cpp b/ELF/Writer.cpp
index dce9283..fc18e4f 100644
--- a/ELF/Writer.cpp
+++ b/ELF/Writer.cpp
@@ -2549,17 +2549,6 @@
   return first->offset + os->addr - first->addr;
 }
 
-// Set an in-file position to a given section and returns the end position of
-// the section.
-static uint64_t setFileOffset(OutputSection *os, uint64_t off) {
-  off = computeFileOffset(os, off);
-  os->offset = off;
-
-  if (os->type == SHT_NOBITS)
-    return off;
-  return off + os->size;
-}
-
 template <class ELFT> void Writer<ELFT>::assignFileOffsetsBinary() {
   // Compute the minimum LMA of all non-empty non-NOBITS sections as minAddr.
   auto needsOffset = [](OutputSection &sec) {
@@ -2601,7 +2590,10 @@
   for (OutputSection *sec : outputSections) {
     if (!(sec->flags & SHF_ALLOC))
       continue;
-    off = setFileOffset(sec, off);
+    off = computeFileOffset(sec, off);
+    sec->offset = off;
+    if (sec->type != SHT_NOBITS)
+      off += sec->size;
 
     // If this is a last section of the last executable segment and that
     // segment is the last loadable segment, align the offset of the
@@ -2610,9 +2602,11 @@
         lastRX->lastSec == sec)
       off = alignTo(off, config->maxPageSize);
   }
-  for (OutputSection *sec : outputSections)
-    if (!(sec->flags & SHF_ALLOC))
-      off = setFileOffset(sec, off);
+  for (OutputSection *osec : outputSections)
+    if (!(osec->flags & SHF_ALLOC)) {
+      osec->offset = alignTo(off, osec->alignment);
+      off = osec->offset + osec->size;
+    }
 
   sectionHeaderOff = alignTo(off, config->wordsize);
   fileSize = sectionHeaderOff + (outputSections.size() + 1) * sizeof(Elf_Shdr);