commit c7600a945a455742ec67e7f4445f9f0efc786664
author Fangrui Song <i@maskray.me> Mon Mar 25 15:46:51 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Mar 25 15:53:42 2024 -0700
tree 0a46ee75fc2b19be0cad41a3f97bbae24f499503
parent 9527e113256b27d0d3cd4a211883ee770269b06e

[ELF] Simplify parseArmCMSEImportLib. NFC

GitOrigin-RevId: dd7151094f94bc45668cf8629f02fe6f1975d5c9

ELF/Config.h

diff --git a/ELF/Config.h b/ELF/Config.h
index bb3608d..27274d6 100644
--- a/ELF/Config.h
+++ b/ELF/Config.h
@@ -138,7 +138,7 @@
 
   std::unique_ptr<BitcodeCompiler> lto;
   std::vector<InputFile *> files;
-  std::optional<InputFile *> armCmseImpLib;
+  InputFile *armCmseImpLib = nullptr;
 
 public:
   SmallVector<std::pair<StringRef, unsigned>, 0> archiveFiles;

ELF/InputFiles.cpp

diff --git a/ELF/InputFiles.cpp b/ELF/InputFiles.cpp
index 4c614c8..1104433 100644
--- a/ELF/InputFiles.cpp
+++ b/ELF/InputFiles.cpp
@@ -330,11 +330,11 @@
 extern template void ObjFile<ELF64LE>::importCmseSymbols();
 extern template void ObjFile<ELF64BE>::importCmseSymbols();
 
-template <class ELFT> static void doParseArmCMSEImportLib(InputFile *file) {
-  cast<ObjFile<ELFT>>(file)->importCmseSymbols();
+template <class ELFT> static void doParseArmCMSEImportLib(InputFile &file) {
+  cast<ObjFile<ELFT>>(file).importCmseSymbols();
 }
 
-void elf::parseArmCMSEImportLib(InputFile *file) {
+void elf::parseArmCMSEImportLib(InputFile &file) {
   invokeELFT(doParseArmCMSEImportLib, file);
 }
 

ELF/InputFiles.h

diff --git a/ELF/InputFiles.h b/ELF/InputFiles.h
index 3beb5a3..7d5dd34 100644
--- a/ELF/InputFiles.h
+++ b/ELF/InputFiles.h
@@ -49,7 +49,7 @@
 template <class ELFT> void doParseFile(InputFile *file);
 void parseFile(InputFile *file);
 
-void parseArmCMSEImportLib(InputFile *file);
+void parseArmCMSEImportLib(InputFile &file);
 
 // The root class of input files.
 class InputFile {