commit a78c9afc788ed8cda3b2dd081e27edd390e1f686
author Kazu Hirata <kazu@google.com> Fri Jan 12 22:08:26 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Jan 12 22:11:01 2024 -0800
tree 60a060945da24896388a6ff82de49261a45510bd
parent 3052b1954277325586f15615f4e4ec55e7a92307

[lld] Use StringRef::consume_front_insensitive (NFC)

GitOrigin-RevId: 51fb76ff1d4a888342c4a406904096b32cc49866

COFF/DriverUtils.cpp

diff --git a/COFF/DriverUtils.cpp b/COFF/DriverUtils.cpp
index ab10e2d..4678767 100644
--- a/COFF/DriverUtils.cpp
+++ b/COFF/DriverUtils.cpp
@@ -310,13 +310,11 @@
     arg = arg.ltrim();
     if (arg.empty())
       return;
-    if (arg.starts_with_insensitive("level=")) {
-      arg = arg.substr(strlen("level="));
+    if (arg.consume_front_insensitive("level=")) {
       std::tie(ctx.config.manifestLevel, arg) = arg.split(" ");
       continue;
     }
-    if (arg.starts_with_insensitive("uiaccess=")) {
-      arg = arg.substr(strlen("uiaccess="));
+    if (arg.consume_front_insensitive("uiaccess=")) {
       std::tie(ctx.config.manifestUIAccess, arg) = arg.split(" ");
       continue;
     }

Common/Args.cpp

diff --git a/Common/Args.cpp b/Common/Args.cpp
index 48c934d..67d7bab 100644
--- a/Common/Args.cpp
+++ b/Common/Args.cpp
@@ -31,8 +31,8 @@
 
   int64_t v;
   StringRef s = a->getValue();
-  if (base == 16 && (s.starts_with("0x") || s.starts_with("0X")))
-    s = s.drop_front(2);
+  if (base == 16)
+    s.consume_front_insensitive("0x");
   if (to_integer(s, v, base))
     return v;
 

MachO/Driver.cpp

diff --git a/MachO/Driver.cpp b/MachO/Driver.cpp
index 5885a1f..401459a 100644
--- a/MachO/Driver.cpp
+++ b/MachO/Driver.cpp
@@ -952,8 +952,7 @@
     StringRef segName = arg->getValue(0);
     StringRef sectName = arg->getValue(1);
     StringRef alignStr = arg->getValue(2);
-    if (alignStr.starts_with("0x") || alignStr.starts_with("0X"))
-      alignStr = alignStr.drop_front(2);
+    alignStr.consume_front_insensitive("0x");
     uint32_t align;
     if (alignStr.getAsInteger(16, align)) {
       error("-sectalign: failed to parse '" + StringRef(arg->getValue(2)) +