[IR] Change representation of getelementptr inrange (#84341)
As part of the migration to ptradd
(https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699),
we need to change the representation of the `inrange` attribute, which
is used for vtable splitting.
Currently, inrange is specified as follows:
```
getelementptr inbounds ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, inrange i32 1, i64 2)
```
The `inrange` is placed on a GEP index, and all accesses must be "in
range" of that index. The new representation is as follows:
```
getelementptr inbounds inrange(-16, 16) ({ [4 x ptr], [4 x ptr] }, ptr @vt, i64 0, i32 1, i64 2)
```
This specifies which offsets are "in range" of the GEP result. The new
representation will continue working when canonicalizing to ptradd
representation:
```
getelementptr inbounds inrange(-16, 16) (i8, ptr @vt, i64 48)
```
The inrange offsets are relative to the return value of the GEP. An
alternative design could make them relative to the source pointer
instead. The result-relative format was chosen on the off-chance that we
want to extend support to non-constant GEPs in the future, in which case
this variant is more expressive.
This implementation "upgrades" the old inrange representation in bitcode
by simply dropping it. This is a very niche feature, and I don't think
trying to upgrade it is worthwhile. Let me know if you disagree.
GitOrigin-RevId: 0f46e31cfbf415fcd3d3ce121bef94e92c6ccfc8
diff --git a/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_ref.ll b/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_ref.ll
index 43df836..8219b8b 100644
--- a/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_ref.ll
+++ b/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_ref.ll
@@ -36,7 +36,7 @@
store ptr %this, ptr %this.addr
%this1 = load ptr, ptr %this.addr
call void @_ZN1AC2Ev(ptr noundef nonnull align 8 dereferenceable(8) %this1)
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV1B, i32 0, inrange i32 0, i32 2), ptr %this1
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV1B, i32 0, i32 0, i32 2), ptr %this1
ret void
}
@@ -47,7 +47,7 @@
%this.addr = alloca ptr
store ptr %this, ptr %this.addr
%this1 = load ptr, ptr %this.addr
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV1A, i32 0, inrange i32 0, i32 2), ptr %this1
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV1A, i32 0, i32 0, i32 2), ptr %this1
ret void
}
diff --git a/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_undef.ll b/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_undef.ll
index 6cc55df..4323094 100644
--- a/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_undef.ll
+++ b/test/ELF/lto/Inputs/devirt_validate_vtable_typeinfos_undef.ll
@@ -9,7 +9,7 @@
%this.addr = alloca ptr, align 8
store ptr %this, ptr %this.addr, align 8
%this1 = load ptr, ptr %this.addr, align 8
- store ptr getelementptr inbounds ({ [4 x ptr] }, ptr @_ZTV1B, i32 0, inrange i32 0, i32 2), ptr %this1, align 8
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [4 x ptr] }, ptr @_ZTV1B, i32 0, i32 0, i32 2), ptr %this1, align 8
ret void
}
diff --git a/test/ELF/lto/devirt_split_unit_localize.ll b/test/ELF/lto/devirt_split_unit_localize.ll
index 04f30dc..fb3564b 100644
--- a/test/ELF/lto/devirt_split_unit_localize.ll
+++ b/test/ELF/lto/devirt_split_unit_localize.ll
@@ -91,7 +91,7 @@
define dso_local void @_Z17useDoThingWithCatv() local_unnamed_addr {
entry:
%call = tail call noalias nonnull dereferenceable(8) ptr @_Znwm(i64 8)
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV3Cat, i64 0, inrange i32 0, i64 2), ptr %call, align 8, !tbaa !4
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV3Cat, i64 0, i32 0, i64 2), ptr %call, align 8, !tbaa !4
tail call void @_Z14doThingWithCatP6Animal(ptr nonnull %call)
ret void
}
diff --git a/test/ELF/lto/devirt_validate_vtable_typeinfos_ref.ll b/test/ELF/lto/devirt_validate_vtable_typeinfos_ref.ll
index 2318af4..2d6a30d 100644
--- a/test/ELF/lto/devirt_validate_vtable_typeinfos_ref.ll
+++ b/test/ELF/lto/devirt_validate_vtable_typeinfos_ref.ll
@@ -117,7 +117,7 @@
%this.addr = alloca ptr, align 8
store ptr %this, ptr %this.addr, align 8
%this1 = load ptr, ptr %this.addr, align 8
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV1A, i32 0, inrange i32 0, i32 2), ptr %this1, align 8
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV1A, i32 0, i32 0, i32 2), ptr %this1, align 8
ret void
}
diff --git a/test/MachO/thinlto-split-unit-start-lib.ll b/test/MachO/thinlto-split-unit-start-lib.ll
index 8c643b7..1c4a2f6 100644
--- a/test/MachO/thinlto-split-unit-start-lib.ll
+++ b/test/MachO/thinlto-split-unit-start-lib.ll
@@ -57,14 +57,14 @@
; Function Attrs: mustprogress nofree norecurse nosync nounwind ssp willreturn memory(argmem: write) uwtable
define void @_ZN1SC2Ev(ptr nocapture noundef nonnull writeonly align 8 dereferenceable(8) %this) unnamed_addr align 2 {
entry:
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV1S, i64 0, inrange i32 0, i64 2), ptr %this, align 8
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV1S, i64 0, i32 0, i64 2), ptr %this, align 8
ret void
}
; Function Attrs: mustprogress nofree norecurse nosync nounwind ssp willreturn memory(argmem: write) uwtable
define void @_ZN1SC1Ev(ptr nocapture noundef nonnull writeonly align 8 dereferenceable(8) %this) unnamed_addr align 2 {
entry:
- store ptr getelementptr inbounds ({ [3 x ptr] }, ptr @_ZTV1S, i64 0, inrange i32 0, i64 2), ptr %this, align 8
+ store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV1S, i64 0, i32 0, i64 2), ptr %this, align 8
ret void
}
