commit 76095175ff0efdc939f39d1b608c23d011d1d9d3
author Dave Lee <davelee.com@gmail.com> Mon Sep 21 10:22:51 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 29 18:05:54 2020 -0700
tree 9f7045bdf4e24140bf73fa6f441b0042f6f631ee
parent 5297cd9f821a7a65428f147095934b9a2db4eede

[cmake] Centralize LLVM_ENABLE_WARNINGS option

Configure default value of `LLVM_ENABLE_WARNINGS` in `HandleLLVMOptions.cmake`.

`LLVM_ENABLE_WARNINGS` is documented as ON by default, but `HandleLLVMOptions` assumes the default has been set somewhere else. If it has not been explicitly set, then `HandleLLVMOptions` implicitly uses OFF as a default.

This removes the various `option()` declarations in favor of a single declaration in `HandleLLVMOptions`. This will prevent the unwanted use of `-w` that is mentioned in a couple of the comments.

Reviewed By: DavidTruby, #libunwind, JDevlieghere, compnerd

Differential Revision: https://reviews.llvm.org/D87243

GitOrigin-RevId: b36bdfe5ca0c2b863248f327b03d41516b38dc11

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f4243f3..7851f3e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -73,8 +73,6 @@
   endif()
 
   if (EXISTS ${LLVM_CMAKE_PATH})
-    # Enable warnings, otherwise -w gets added to the cflags by HandleLLVMOptions.
-    set(LLVM_ENABLE_WARNINGS ON)
     list(APPEND CMAKE_MODULE_PATH "${LLVM_CMAKE_PATH}")
     include("${LLVM_CMAKE_PATH}/AddLLVM.cmake")
     include("${LLVM_CMAKE_PATH}/HandleLLVMOptions.cmake")