commit 45022166feef88f59dc6e3c6b2304fe3a49d1c19
author Louis Dionne <ldionne@apple.com> Tue Aug 11 15:29:00 2020 -0400
committer Copybara-Service <copybara-worker@google.com> Fri Aug 28 11:18:07 2020 -0700
tree ec811f3267a5692e485be839d04bfc6cf68802ff
parent 0469bcfa76df187f405ce3b625d031ff24e8a157

[libunwind] Fix incorrect check for out-of-boundedness

If the personalityIndex (which is 0-based) is equal to the length of
the personality array, we should error out.

rdar://18013273

GitOrigin-RevId: 9b211a5076310f14081dd257b0cbac6857534bc3

src/UnwindCursor.hpp

diff --git a/src/UnwindCursor.hpp b/src/UnwindCursor.hpp
index 48902ea..03e21fb 100644
--- a/src/UnwindCursor.hpp
+++ b/src/UnwindCursor.hpp
@@ -1764,7 +1764,7 @@
                               (__builtin_ctz(UNWIND_PERSONALITY_MASK));
   if (personalityIndex != 0) {
     --personalityIndex; // change 1-based to zero-based index
-    if (personalityIndex > sectionHeader.personalityArrayCount()) {
+    if (personalityIndex >= sectionHeader.personalityArrayCount()) {
       _LIBUNWIND_DEBUG_LOG("found encoding 0x%08X with personality index %d,  "
                             "but personality table has only %d entries",
                             encoding, personalityIndex,