[libc++] Avoid potential truncation warnings in std::abs test
One some platforms, -Wimplicit-int-conversion is enabled by default,
which can lead to additional warnings being triggered in this test.
Since we're only trying to test errors related to calling abs(), the
assignment is superfluous.
As a fly-by fix, correct one instance of ::abs to std::abs and made
the test a .verify.cpp test instead.
Differential Revision: https://reviews.llvm.org/D114244
GitOrigin-RevId: 1b4c0cb3918a9f2d12f8259407fc8bce053e78bf
diff --git a/test/std/numerics/c.math/abs.fail.cpp b/test/std/numerics/c.math/abs.fail.cpp
deleted file mode 100644
index d58cf0d..0000000
--- a/test/std/numerics/c.math/abs.fail.cpp
+++ /dev/null
@@ -1,31 +0,0 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include <cmath>
-
-#include "test_macros.h"
-
-int main(int, char**)
-{
- unsigned int ui = -5;
- ui = std::abs(ui); // expected-error {{call to 'abs' is ambiguous}}
-
- unsigned char uc = -5;
- uc = std::abs(uc); // expected-warning {{taking the absolute value of unsigned type 'unsigned char' has no effect}}
-
- unsigned short us = -5;
- us = std::abs(us); // expected-warning {{taking the absolute value of unsigned type 'unsigned short' has no effect}}
-
- unsigned long ul = -5;
- ul = std::abs(ul); // expected-error {{call to 'abs' is ambiguous}}
-
- unsigned long long ull = -5;
- ull = ::abs(ull); // expected-error {{call to 'abs' is ambiguous}}
-
- return 0;
-}
diff --git a/test/std/numerics/c.math/abs.verify.cpp b/test/std/numerics/c.math/abs.verify.cpp
new file mode 100644
index 0000000..dec8076
--- /dev/null
+++ b/test/std/numerics/c.math/abs.verify.cpp
@@ -0,0 +1,26 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include <cmath>
+
+void f() {
+ unsigned int ui = -5;
+ (void)std::abs(ui); // expected-error {{call to 'abs' is ambiguous}}
+
+ unsigned char uc = -5;
+ (void)std::abs(uc); // expected-warning {{taking the absolute value of unsigned type 'unsigned char' has no effect}}
+
+ unsigned short us = -5;
+ (void)std::abs(us); // expected-warning {{taking the absolute value of unsigned type 'unsigned short' has no effect}}
+
+ unsigned long ul = -5;
+ (void)std::abs(ul); // expected-error {{call to 'abs' is ambiguous}}
+
+ unsigned long long ull = -5;
+ (void)std::abs(ull); // expected-error {{call to 'abs' is ambiguous}}
+}
