commit 535d1ecee3fa183fb6ff29447dad9aa8cdc8e25d
author Joerg Sonnenberger <joerg@bec.de> Wed Feb 17 22:13:01 2021 +0100
committer Copybara-Service <copybara-worker@google.com> Fri Feb 19 01:07:44 2021 -0800
tree a9626d5ef1580a4f25ebaa90660c12476fb3a50e
parent 4895a175b57441f5f708142e2c6f84a75ded620f

libcxx: use early returns

Differential Revision: https://reviews.llvm.org/D96955

GitOrigin-RevId: a77e918016043691246d61f045519aaa5bc200f5

src/filesystem/operations.cpp

diff --git a/src/filesystem/operations.cpp b/src/filesystem/operations.cpp
index 88a039f..458ba16 100644
--- a/src/filesystem/operations.cpp
+++ b/src/filesystem/operations.cpp
@@ -1051,7 +1051,7 @@
 
   StatT attr_stat;
   error_code mec;
-  auto st = detail::posix_stat(attributes, attr_stat, &mec);
+  file_status st = detail::posix_stat(attributes, attr_stat, &mec);
   if (!status_known(st))
     return err.report(mec);
   if (!is_directory(st))
@@ -1061,16 +1061,14 @@
   if (detail::mkdir(p.c_str(), attr_stat.st_mode) == 0)
     return true;
 
-  if (errno == EEXIST) {
-    error_code mec = capture_errno();
-    error_code ignored_ec;
-    const file_status st = status(p, ignored_ec);
-    if (!is_directory(st)) {
-      err.report(mec);
-    }
-  } else {
-    err.report(capture_errno());
-  }
+  if (errno != EEXIST)
+    return err.report(capture_errno());
+
+  mec = capture_errno();
+  error_code ignored_ec;
+  st = status(p, ignored_ec);
+  if (!is_directory(st))
+    return err.report(mec);
   return false;
 }