[libcxx] [test] Add return values after assert(false) in some experimental tests
When building in MSVC mode (in release mode), the assert(false) don't
make the end of the function unreachable, so add return statements to
silence compiler warnings (treated as errors).
Also change 'virtual' into 'override', which was requested in review,
as these files require C++11.
Differential Revision: https://reviews.llvm.org/D99214
GitOrigin-RevId: b6c4b280a01f1a16b0b4258a1034bebc13f1f7e3
diff --git a/test/std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp b/test/std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp
index 8c7af9d..91bf1f5 100644
--- a/test/std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp
+++ b/test/std/experimental/memory/memory.resource.global/new_delete_resource.pass.cpp
@@ -25,14 +25,14 @@
struct assert_on_compare : public ex::memory_resource
{
protected:
- virtual void * do_allocate(size_t, size_t)
+ void * do_allocate(size_t, size_t) override
+ { assert(false); return nullptr; }
+
+ void do_deallocate(void *, size_t, size_t) override
{ assert(false); }
- virtual void do_deallocate(void *, size_t, size_t)
- { assert(false); }
-
- virtual bool do_is_equal(ex::memory_resource const &) const noexcept
- { assert(false); }
+ bool do_is_equal(ex::memory_resource const &) const noexcept override
+ { assert(false); return false; }
};
void test_return()
diff --git a/test/std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp b/test/std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp
index c7efeab..bdd6248 100644
--- a/test/std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp
+++ b/test/std/experimental/memory/memory.resource.global/null_memory_resource.pass.cpp
@@ -25,14 +25,14 @@
struct assert_on_compare : public ex::memory_resource
{
protected:
- virtual void * do_allocate(size_t, size_t)
+ void * do_allocate(size_t, size_t) override
+ { assert(false); return nullptr; }
+
+ void do_deallocate(void *, size_t, size_t) override
{ assert(false); }
- virtual void do_deallocate(void *, size_t, size_t)
- { assert(false); }
-
- virtual bool do_is_equal(ex::memory_resource const &) const noexcept
- { assert(false); }
+ bool do_is_equal(ex::memory_resource const &) const noexcept override
+ { assert(false); return false; }
};
void test_return()
