commit 603d085fc5530c9d1a37b1be2cc96be32324dbac
author luolent <56246516+luolent@users.noreply.github.com> Sat May 04 20:38:45 2024 +0300
committer Copybara-Service <copybara-worker@google.com> Sat May 04 10:44:49 2024 -0700
tree 05055ee1056cba7a6e898f85b5d6fc5ae6bb52e7
parent cd0867781f8bea1c34fdfe853f1ae7b9dd2ece9b

Add clarifying parenthesis around non-trivial conditions in ternary expressions. (#90391)

Fixes [#85868](https://github.com/llvm/llvm-project/issues/85868)

Parenthesis are added as requested on ternary operators with non trivial conditions.

I used this [precedence table](https://en.cppreference.com/w/cpp/language/operator_precedence) for reference, to make sure we get the expected behavior on each change.

GitOrigin-RevId: a98a6e95be1be9a5c28da15b4d19a6f39872461d

generic/lib/math/log_base.h

diff --git a/generic/lib/math/log_base.h b/generic/lib/math/log_base.h
index f5b6f1c..2558f01 100644
--- a/generic/lib/math/log_base.h
+++ b/generic/lib/math/log_base.h
@@ -289,7 +289,7 @@
     double ret = is_near ? ret_near : ret_far;
 
     ret = isinf(x) ? as_double(PINFBITPATT_DP64) : ret;
-    ret = isnan(x) | (x < 0.0) ? as_double(QNANBITPATT_DP64) : ret;
+    ret = (isnan(x) | (x < 0.0)) ? as_double(QNANBITPATT_DP64) : ret;
     ret = x == 0.0 ? as_double(NINFBITPATT_DP64) : ret;
     return ret;
 }