commit e87cf8c6f4e3a0f1eb3b8af2774008dd1921f295
author Michael Jones <michaelrj@google.com> Wed Jan 13 21:36:05 2021 +0000
committer Copybara-Service <copybara-worker@google.com> Wed Jan 13 14:36:26 2021 -0800
tree 0eb00a7f9983fd4cb48a01f57eb6960a11f84045
parent 8dcecebba8964aac9e394dd1f40547eea76434a8

[libc][NFC] change isblank and iscntrl from implicit casting

isblank and iscntrl were casting an int to a char implicitly and this
was throwing errors under Fuchsia. I've added a static cast to resolve
this issue.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D94634

GitOrigin-RevId: ea8034ec35a9e3d6784d7e6f50617af3d87f6a9f

src/ctype/isblank.cpp

diff --git a/src/ctype/isblank.cpp b/src/ctype/isblank.cpp
index b29d19a..1c30613 100644
--- a/src/ctype/isblank.cpp
+++ b/src/ctype/isblank.cpp
@@ -15,7 +15,7 @@
 // TODO: Currently restricted to default locale.
 // These should be extended using locale information.
 LLVM_LIBC_FUNCTION(int, isblank, (int c)) {
-  const unsigned char ch = c;
+  const unsigned char ch = static_cast<char>(c);
   return ch == ' ' || ch == '\t';
 }
 

src/ctype/iscntrl.cpp

diff --git a/src/ctype/iscntrl.cpp b/src/ctype/iscntrl.cpp
index 8962bca..b061199 100644
--- a/src/ctype/iscntrl.cpp
+++ b/src/ctype/iscntrl.cpp
@@ -15,7 +15,7 @@
 // TODO: Currently restricted to default locale.
 // These should be extended using locale information.
 LLVM_LIBC_FUNCTION(int, iscntrl, (int c)) {
-  const unsigned char ch = c;
+  const unsigned char ch = static_cast<char>(c);
   return ch < 0x20 || ch == 0x7f;
 }