[libc] Check signs instead of values in memcmp unittests.
The C standard only guarantees the sign of return value. The exact return
value is implementation defined.
Reviewed By: gchatelet
Differential Revision: https://reviews.llvm.org/D109588
GitOrigin-RevId: 2fc1913505e3d5f48b3d5d84ce372a34e661fc7e
diff --git a/test/src/string/memcmp_test.cpp b/test/src/string/memcmp_test.cpp
index 9be1e56..35ee741 100644
--- a/test/src/string/memcmp_test.cpp
+++ b/test/src/string/memcmp_test.cpp
@@ -11,7 +11,7 @@
TEST(LlvmLibcMemcmpTest, CmpZeroByte) {
const char *lhs = "ab";
- const char *rhs = "bc";
+ const char *rhs = "yz";
EXPECT_EQ(__llvm_libc::memcmp(lhs, rhs, 0), 0);
}
@@ -23,14 +23,14 @@
TEST(LlvmLibcMemcmpTest, LhsBeforeRhsLexically) {
const char *lhs = "ab";
- const char *rhs = "ac";
- EXPECT_EQ(__llvm_libc::memcmp(lhs, rhs, 2), -1);
+ const char *rhs = "az";
+ EXPECT_LT(__llvm_libc::memcmp(lhs, rhs, 2), 0);
}
TEST(LlvmLibcMemcmpTest, LhsAfterRhsLexically) {
- const char *lhs = "ac";
+ const char *lhs = "az";
const char *rhs = "ab";
- EXPECT_EQ(__llvm_libc::memcmp(lhs, rhs, 2), 1);
+ EXPECT_GT(__llvm_libc::memcmp(lhs, rhs, 2), 0);
}
TEST(LlvmLibcMemcmpTest, Sweep) {
@@ -51,8 +51,8 @@
reset(lhs);
reset(rhs);
for (size_t i = 0; i < kMaxSize; ++i) {
- rhs[i] = 'b';
- EXPECT_EQ(__llvm_libc::memcmp(lhs, rhs, kMaxSize), -1);
+ rhs[i] = 'z';
+ EXPECT_LT(__llvm_libc::memcmp(lhs, rhs, kMaxSize), 0);
rhs[i] = 'a';
}
}