commit edc57ed5190c195b13d77e1a2a611eaaab183202
author Peter Klausler <35819229+klausler@users.noreply.github.com> Tue Mar 26 10:02:22 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 26 10:05:17 2024 -0700
tree fa9f6966a7cdd6723f8633f9169022c106c81997
parent 68ac8050bf226c99d55cbf66fb0d72e6cf2fd501

[flang][NFC] Address reported "possible missing return" (#86523)

A function uses "if constexpr" to consider all possible types in a
variant, but looks as if it can fall out without returning an
expression. Add a final "else" with a crash to make things more clear
and to protect against unlikely future extensions of the type.

Fixes https://github.com/llvm/llvm-project/issues/86391.

GitOrigin-RevId: f92f77521263c8f20171b62688ecc86de9c9dfa9

lib/Semantics/tools.cpp

diff --git a/lib/Semantics/tools.cpp b/lib/Semantics/tools.cpp
index 2230047..654ebb1 100644
--- a/lib/Semantics/tools.cpp
+++ b/lib/Semantics/tools.cpp
@@ -1287,6 +1287,8 @@
     return !IsPointer(component);
   } else if constexpr (componentKind == ComponentKind::PotentialAndPointer) {
     return true;
+  } else {
+    DIE("unexpected ComponentKind");
   }
 }