commit b55c97ac4cba774a0d2f279090d802283b288bc6
author Valentin Clement <clementval@gmail.com> Fri Sep 24 18:49:40 2021 +0200
committer Copybara-Service <copybara-worker@google.com> Fri Sep 24 09:56:05 2021 -0700
tree 52b29c7749a0cf9f647fe8d5b5b9ed9a18b01a79
parent a7b551f30546ed96e6958ff30665bdc4e0319065

Revert "[flang][fir] Add support to mangle/deconstruct namelist group name"

This reverts commit 3593ae4312f6156c9ca50d46cdb55a8dfad782d0.

GitOrigin-RevId: 321be24aa6808c5829f3433407e13603901849f4

include/flang/Optimizer/Support/InternalNames.h

diff --git a/include/flang/Optimizer/Support/InternalNames.h b/include/flang/Optimizer/Support/InternalNames.h
index 36e3ed0..fa98cc2 100644
--- a/include/flang/Optimizer/Support/InternalNames.h
+++ b/include/flang/Optimizer/Support/InternalNames.h
@@ -41,8 +41,7 @@
     INTRINSIC_TYPE_DESC,
     PROCEDURE,
     TYPE_DESC,
-    VARIABLE,
-    NAMELIST_GROUP
+    VARIABLE
   };
 
   /// Components of an unparsed unique name
@@ -113,11 +112,6 @@
                                 llvm::Optional<llvm::StringRef> host,
                                 llvm::StringRef name);
 
-  /// Unique a namelist group name
-  static std::string doNamelistGroup(llvm::ArrayRef<llvm::StringRef> modules,
-                                     llvm::Optional<llvm::StringRef> host,
-                                     llvm::StringRef name);
-
   /// Entry point for the PROGRAM (called by the runtime)
   /// Can be overridden with the `--main-entry-name=<name>` option.
   static llvm::StringRef doProgramEntry();

lib/Lower/Mangler.cpp

diff --git a/lib/Lower/Mangler.cpp b/lib/Lower/Mangler.cpp
index f74afc5..07d9e63 100644
--- a/lib/Lower/Mangler.cpp
+++ b/lib/Lower/Mangler.cpp
@@ -114,12 +114,6 @@
                                                   symbolName);
             return fir::NameUniquer::doVariable(modNames, optHost, symbolName);
           },
-          [&](const Fortran::semantics::NamelistDetails &) {
-            auto modNames = moduleNames(ultimateSymbol);
-            auto optHost = hostName(ultimateSymbol);
-            return fir::NameUniquer::doNamelistGroup(modNames, optHost,
-                                                     symbolName);
-          },
           [&](const Fortran::semantics::CommonBlockDetails &) {
             return fir::NameUniquer::doCommonBlock(symbolName);
           },

lib/Optimizer/Support/InternalNames.cpp

diff --git a/lib/Optimizer/Support/InternalNames.cpp b/lib/Optimizer/Support/InternalNames.cpp
index bd28163..a7493d7 100644
--- a/lib/Optimizer/Support/InternalNames.cpp
+++ b/lib/Optimizer/Support/InternalNames.cpp
@@ -205,15 +205,6 @@
   return result.append(toLower(name));
 }
 
-std::string
-fir::NameUniquer::doNamelistGroup(llvm::ArrayRef<llvm::StringRef> modules,
-                                  llvm::Optional<llvm::StringRef> host,
-                                  llvm::StringRef name) {
-  std::string result = prefix();
-  result.append(doModulesHost(modules, host)).append("G");
-  return result.append(toLower(name));
-}
-
 llvm::StringRef fir::NameUniquer::doProgramEntry() {
   if (mainEntryName.size())
     return mainEntryName;
@@ -288,10 +279,6 @@
         else
           kinds.push_back(readInt(uniq, i, i + 1, end));
         break;
-      case 'G':
-        nk = NameKind::NAMELIST_GROUP;
-        name = readName(uniq, i, i + 1, end);
-        break;
 
       default:
         assert(false && "unknown uniquing code");

unittests/Optimizer/InternalNamesTest.cpp

diff --git a/unittests/Optimizer/InternalNamesTest.cpp b/unittests/Optimizer/InternalNamesTest.cpp
index 1a83766..831d799 100644
--- a/unittests/Optimizer/InternalNamesTest.cpp
+++ b/unittests/Optimizer/InternalNamesTest.cpp
@@ -162,12 +162,6 @@
   ASSERT_EQ(actual.str(), expectedMangledName);
 }
 
-TEST(InternalNamesTest, doNamelistGroup) {
-  llvm::StringRef actual = NameUniquer::doNamelistGroup({"mod1"}, {}, {"nlg"});
-  std::string expectedMangledName = "_QMmod1Gnlg";
-  ASSERT_EQ(actual, expectedMangledName);
-}
-
 TEST(InternalNamesTest, deconstructTest) {
   std::pair actual = NameUniquer::deconstruct("_QBhello");
   auto expectedNameKind = NameUniquer::NameKind::COMMON;
@@ -214,11 +208,6 @@
   expectedNameKind = NameKind::DISPATCH_TABLE;
   expectedComponents = {{}, {}, "t", {}};
   validateDeconstructedName(actual, expectedNameKind, expectedComponents);
-
-  actual = NameUniquer::deconstruct("_QFmstartGmpitop");
-  expectedNameKind = NameKind::NAMELIST_GROUP;
-  expectedComponents = {{}, {"mstart"}, "mpitop", {}};
-  validateDeconstructedName(actual, expectedNameKind, expectedComponents);
 }
 
 // main() from gtest_main