[mlir] avoid exposing mutable DialectRegistry from MLIRContext
MLIRContext allows its users to access directly to the DialectRegistry it
contains. While sometimes useful for registering additional dialects on an
already existing context, this breaks the encapsulation by essentially giving
raw accesses to a part of the context's internal state. Remove this mutable
access and instead provide a method to append a given DialectRegistry to the
one already contained in the context. Also provide a shortcut mechanism to
construct a context from an already existing registry, which seems to be a
common use case in the wild. Keep read-only access to the registry contained in
the context in case it needs to be copied or used for constructing another
context.
With this change, DialectRegistry is no longer concerned with loading the
dialects and deciding whether to invoke delayed interface registration. Loading
is concentrated in the MLIRContext, and the functionality of the registry
better reflects its name.
Depends On D96137
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D96331
GitOrigin-RevId: 2996a8d67553b9d469e01215b49bb1af17ad6d1e
diff --git a/tools/tco/tco.cpp b/tools/tco/tco.cpp
index 5931d7b..49f3547 100644
--- a/tools/tco/tco.cpp
+++ b/tools/tco/tco.cpp
@@ -61,8 +61,9 @@
// load the file into a module
SourceMgr sourceMgr;
sourceMgr.AddNewSourceBuffer(std::move(*fileOrErr), SMLoc());
- mlir::MLIRContext context;
- fir::registerFIRDialects(context.getDialectRegistry());
+ mlir::DialectRegistry registry;
+ fir::registerFIRDialects(registry);
+ mlir::MLIRContext context(registry);
auto owningRef = mlir::parseSourceFile(sourceMgr, &context);
if (!owningRef) {
