[scudo] Clean up zero on deallocate change. (#244070)

Instead of having a separate bool for Zero in the secondary cache entry,
use the already existing Flags instead.

Fix bug where a secondary cache entry is zeroed by releasing to the
kernel, but the entry was not marked as being zeroed. Update the test
for this since it was wrong too.

Move the zeroing of the entry so that if the secondary quarantine is
enabled, the entry is zeroed before being put in quarantine.
Move the zeroing outside of the lock when zero on deallocate is enabled.

Use the ClassId value in combined.h instead of using Header->ClassId.

BUG=b:581873117
BUG=b:582375770
GitOrigin-RevId: 2bee3e393405d26213834265dd4478e88ff96d30
3 files changed