commit 84103e95f19924f8d59914415993bb7e053f37aa
author Vitaly Buka <vitalybuka@google.com> Thu Dec 02 00:53:02 2021 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Dec 02 11:51:14 2021 -0800
tree c2f21b29486ca47c4f4c3d4152498fef6f4c258c
parent eb3a08288cc5901062348492d0fecf6bb289d928

[asan] Remove confusing workaround

The goal is to identify the bot and try to fix it.

SetSoftRssLimitExceededCallback is AsanInitInternal as I assume
that only MaybeStartBackgroudThread needs to be delayed to constructors.
Later I want to move MaybeStartBackgroudThread call into sanitizer_common.

If it needs to be reverted please provide to more info, like bot, or details about setup.

Reviewed By: kstoimenov

Differential Revision: https://reviews.llvm.org/D114934

GitOrigin-RevId: 67207797e95bbf119199ef95b9eb4c9877a09152

lib/asan/asan_rtl.cpp

diff --git a/lib/asan/asan_rtl.cpp b/lib/asan/asan_rtl.cpp
index 5be8ef0..eb60661 100644
--- a/lib/asan/asan_rtl.cpp
+++ b/lib/asan/asan_rtl.cpp
@@ -371,18 +371,10 @@
           kHighShadowBeg > kMidMemEnd);
 }
 
-#if defined(__thumb__) && defined(__linux__)
-#define START_BACKGROUND_THREAD_IN_ASAN_INTERNAL
-#endif
-
-#ifndef START_BACKGROUND_THREAD_IN_ASAN_INTERNAL
 static bool UNUSED __local_asan_dyninit = [] {
   MaybeStartBackgroudThread();
-  SetSoftRssLimitExceededCallback(AsanSoftRssLimitExceededCallback);
-
   return false;
 }();
-#endif
 
 static void AsanInitInternal() {
   if (LIKELY(asan_inited)) return;
@@ -458,10 +450,7 @@
   allocator_options.SetFrom(flags(), common_flags());
   InitializeAllocator(allocator_options);
 
-#ifdef START_BACKGROUND_THREAD_IN_ASAN_INTERNAL
-  MaybeStartBackgroudThread();
   SetSoftRssLimitExceededCallback(AsanSoftRssLimitExceededCallback);
-#endif
 
   // On Linux AsanThread::ThreadStart() calls malloc() that's why asan_inited
   // should be set to 1 prior to initializing the threads.