commit b4776c84cd18048328aec8e30aeaa1c9145ad4ed
author Nathan James <n.james93@hotmail.co.uk> Mon Apr 12 15:13:59 2021 +0100
committer Copybara-Service <copybara-worker@google.com> Mon Apr 12 11:18:15 2021 -0700
tree fa96ce609a802a8f845f667039a82a23d7f92eb3
parent aa0126d61a2e5a719682d2cdea9a663e26009058

[NFC] Remove redundant string copy

GitOrigin-RevId: bcbea2ab84df87983fa9b30e94ea25eda0eb2338

include/clang/AST/TextNodeDumper.h

diff --git a/include/clang/AST/TextNodeDumper.h b/include/clang/AST/TextNodeDumper.h
index 15ca348..0955c49 100644
--- a/include/clang/AST/TextNodeDumper.h
+++ b/include/clang/AST/TextNodeDumper.h
@@ -69,10 +69,8 @@
       return;
     }
 
-    // We need to capture an owning-string in the lambda because the lambda
-    // is invoked in a deferred manner.
-    std::string LabelStr(Label);
-    auto DumpWithIndent = [this, DoAddChild, LabelStr](bool IsLastChild) {
+    auto DumpWithIndent = [this, DoAddChild,
+                           Label(Label.str())](bool IsLastChild) {
       // Print out the appropriate tree structure and work out the prefix for
       // children of this node. For instance:
       //
@@ -89,8 +87,8 @@
         OS << '\n';
         ColorScope Color(OS, ShowColors, IndentColor);
         OS << Prefix << (IsLastChild ? '`' : '|') << '-';
-        if (!LabelStr.empty())
-          OS << LabelStr << ": ";
+        if (!Label.empty())
+          OS << Label << ": ";
 
         this->Prefix.push_back(IsLastChild ? ' ' : '|');
         this->Prefix.push_back(' ');