[clang][ASTImporter] Fix -Wpessimizing-move in ASTImporter.cpp (NFC)
/llvm-project/clang/lib/AST/ASTImporter.cpp:371:20: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(Err);
^
/llvm-project/clang/lib/AST/ASTImporter.cpp:371:20: note: remove std::move call here
return std::move(Err);
^~~~~~~~~~ ~
/llvm-project/clang/lib/AST/ASTImporter.cpp:380:22: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(Err);
^
/llvm-project/clang/lib/AST/ASTImporter.cpp:380:22: note: remove std::move call here
return std::move(Err);
^~~~~~~~~~ ~
2 errors generated.
GitOrigin-RevId: 30a9cace807d4b5c98f2d0e2bd5bdea49061c8b8
diff --git a/lib/AST/ASTImporter.cpp b/lib/AST/ASTImporter.cpp
index d335e34..e854dbf 100644
--- a/lib/AST/ASTImporter.cpp
+++ b/lib/AST/ASTImporter.cpp
@@ -368,7 +368,7 @@
auto *ToInheritedFrom = const_cast<TemplateParmDeclT *>(
importChecked(Err, D->getDefaultArgStorage().getInheritedFrom()));
if (Err)
- return std::move(Err);
+ return Err;
if (!ToInheritedFrom->hasDefaultArgument()) {
// Resolve possible circular dependency between default value of the
// template argument and the template declaration.
@@ -377,7 +377,7 @@
.getInheritedFrom()
->getDefaultArgument());
if (Err)
- return std::move(Err);
+ return Err;
ToInheritedFrom->setDefaultArgument(Importer.getToContext(),
ToInheritedDefaultArg);
}