commit a56451d0f4cec74e38e2ac31f4b4c2de3c0854ad
author Jie Fu <jiefu@tencent.com> Wed May 31 07:20:24 2023 +0800
committer Copybara-Service <copybara-worker@google.com> Tue May 30 16:26:40 2023 -0700
tree 8c2620ec9bcec8fc2c7fcea3e67277426845d7d7
parent 5b1f555f6173d8d0e6ed277f4b603010e6051e7f

[clang][ExtractAPI] Fix -Wpessimizing-move in DeclarationFragments.h (NFC)

/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
                         ^
/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26: note: remove std::move call here
    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
                         ^~~~~~~~~~
1 error generated.

GitOrigin-RevId: 749aeeaf66a483345e12f69cc1f55dad4e997297

include/clang/ExtractAPI/DeclarationFragments.h

diff --git a/include/clang/ExtractAPI/DeclarationFragments.h b/include/clang/ExtractAPI/DeclarationFragments.h
index 4c1b830..3b909b0 100644
--- a/include/clang/ExtractAPI/DeclarationFragments.h
+++ b/include/clang/ExtractAPI/DeclarationFragments.h
@@ -115,8 +115,8 @@
                                FragmentKind Kind,
                                StringRef PreciseIdentifier = "",
                                const Decl *Declaration = nullptr) {
-    Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
-                                            Declaration)));
+    Fragments.insert(It, Fragment(Spelling, Kind, PreciseIdentifier,
+                                            Declaration));
     return *this;
   }