commit 91efc77b95dbdc26ba0b999a746a22dded920225
author Kadir Cetinkaya <kadircet@google.com> Mon Nov 08 11:16:28 2021 +0100
committer Copybara-Service <copybara-worker@google.com> Wed Nov 17 10:21:17 2021 -0800
tree ac3ab8911c52ec2b4e1189bc1357ed3185950dec
parent b3e11b328efd855abd861981cc344b647b8273a2

[clangd] Dont include file version in task name

This will drop file version information from span names, reducing
overall cardinality and also effect logging when skipping actions in scheduler.

Differential Revision: https://reviews.llvm.org/D113390

GitOrigin-RevId: e76e5729896c4a62f1f5ccbf784a59de96f74cbd

clangd/TUScheduler.cpp

diff --git a/clangd/TUScheduler.cpp b/clangd/TUScheduler.cpp
index e758673..e87aa59 100644
--- a/clangd/TUScheduler.cpp
+++ b/clangd/TUScheduler.cpp
@@ -992,7 +992,7 @@
                                std::shared_ptr<const PreambleData> Preamble,
                                std::vector<Diag> CIDiags,
                                WantDiagnostics WantDiags) {
-  std::string TaskName = llvm::formatv("Build AST for ({0})", PI.Version);
+  llvm::StringLiteral TaskName = "Build AST";
   // Store preamble and build diagnostics with new preamble if requested.
   auto Task = [this, Preamble = std::move(Preamble), CI = std::move(CI),
                PI = std::move(PI), CIDiags = std::move(CIDiags),
@@ -1032,7 +1032,7 @@
   }
   {
     std::lock_guard<std::mutex> Lock(Mutex);
-    PreambleRequests.push_back({std::move(Task), std::move(TaskName),
+    PreambleRequests.push_back({std::move(Task), std::string(TaskName),
                                 steady_clock::now(), Context::current().clone(),
                                 llvm::None, llvm::None,
                                 TUScheduler::NoInvalidation, nullptr});