commit 6e4af40ae2e9055d4dd63590c2bed1e61c1acb55
author Mike Crowe <mac@mcrowe.com> Sun May 05 16:20:31 2024 +0100
committer Copybara-Service <copybara-worker@google.com> Sun May 05 08:27:09 2024 -0700
tree 42f046e31bfa315b0f879fabd19c7c2c9d6c4d7b
parent 041990b610236a6ab34a7a4747d5fcf633f52a9c

[clang-tidy] Improve modernize-use-std-print diagnostic (#91071)

Include the source range of the printf function in the diagnostic so it
gets underlined in the output.

GitOrigin-RevId: 7e4d16d73c22079997dd59d8e7d8f41bdbac5a50

clang-tidy/modernize/UseStdPrintCheck.cpp

diff --git a/clang-tidy/modernize/UseStdPrintCheck.cpp b/clang-tidy/modernize/UseStdPrintCheck.cpp
index 660996a..aa60c90 100644
--- a/clang-tidy/modernize/UseStdPrintCheck.cpp
+++ b/clang-tidy/modernize/UseStdPrintCheck.cpp
@@ -138,7 +138,8 @@
   if (!Converter.canApply()) {
     diag(PrintfCall->getBeginLoc(),
          "unable to use '%0' instead of %1 because %2")
-        << ReplacementFunction << OldFunction->getIdentifier()
+        << PrintfCall->getSourceRange() << ReplacementFunction
+        << OldFunction->getIdentifier()
         << Converter.conversionNotPossibleReason();
     return;
   }