[NFC][clang-tidy]increase stability for bugprone-return-const-ref-from-parameter (#91160)
GitOrigin-RevId: 5cb13bfd897f5d69439058d3cd7b1af8a37c7e42
diff --git a/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp b/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp
index b3f7dd6..cacba38 100644
--- a/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp
+++ b/clang-tidy/bugprone/ReturnConstRefFromParameterCheck.cpp
@@ -29,10 +29,13 @@
void ReturnConstRefFromParameterCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *R = Result.Nodes.getNodeAs<ReturnStmt>("ret");
- diag(R->getRetValue()->getBeginLoc(),
- "returning a constant reference parameter may cause a use-after-free "
+ const SourceRange Range = R->getRetValue()->getSourceRange();
+ if (Range.isInvalid())
+ return;
+ diag(Range.getBegin(),
+ "returning a constant reference parameter may cause use-after-free "
"when the parameter is constructed from a temporary")
- << R->getRetValue()->getSourceRange();
+ << Range;
}
} // namespace clang::tidy::bugprone
