blob: 27a46a43b5190f56c0a29ea096d706632b3379ae [file] [log] [blame]
Philip Reamesf6123222014-12-02 19:37:00 +00001=====================================
2Garbage Collection Safepoints in LLVM
3=====================================
4
5.. contents::
6 :local:
7 :depth: 2
8
9Status
10=======
11
Philip Reames0d98ada2017-04-19 23:16:13 +000012This document describes a set of extensions to LLVM to support garbage
Shao-Ce SUN0c660252021-11-15 09:17:08 +080013collection. By now, these mechanisms are well proven with commercial java
14implementation with a fully relocating collector having shipped using them.
Philip Reames0d98ada2017-04-19 23:16:13 +000015There are a couple places where bugs might still linger; these are called out
16below.
Philip Reamesf6123222014-12-02 19:37:00 +000017
Philip Reames0d98ada2017-04-19 23:16:13 +000018They are still listed as "experimental" to indicate that no forward or backward
Shao-Ce SUN0c660252021-11-15 09:17:08 +080019compatibility guarantees are offered across versions. If your use case is such
20that you need some form of forward compatibility guarantee, please raise the
21issue on the llvm-dev mailing list.
Philip Reames0d98ada2017-04-19 23:16:13 +000022
Shao-Ce SUN0c660252021-11-15 09:17:08 +080023LLVM still supports an alternate mechanism for conservative garbage collection
Philip Reames0d98ada2017-04-19 23:16:13 +000024support using the ``gcroot`` intrinsic. The ``gcroot`` mechanism is mostly of
Sanjoy Das25e71d82017-04-19 23:55:03 +000025historical interest at this point with one exception - its implementation of
Philip Reames0d98ada2017-04-19 23:16:13 +000026shadow stacks has been used successfully by a number of language frontends and
Shao-Ce SUN0c660252021-11-15 09:17:08 +080027is still supported.
Philip Reamesf6123222014-12-02 19:37:00 +000028
Philip Reames9920f8d2018-11-09 16:27:04 +000029Overview & Core Concepts
30========================
Philip Reamesf6123222014-12-02 19:37:00 +000031
Philip Reamesdfc238b2015-01-02 19:46:49 +000032To collect dead objects, garbage collectors must be able to identify
33any references to objects contained within executing code, and,
34depending on the collector, potentially update them. The collector
35does not need this information at all points in code - that would make
36the problem much harder - but only at well-defined points in the
37execution known as 'safepoints' For most collectors, it is sufficient
38to track at least one copy of each unique pointer value. However, for
39a collector which wishes to relocate objects directly reachable from
40running code, a higher standard is required.
Philip Reamesf6123222014-12-02 19:37:00 +000041
Philip Reamesdfc238b2015-01-02 19:46:49 +000042One additional challenge is that the compiler may compute intermediate
43results ("derived pointers") which point outside of the allocation or
44even into the middle of another allocation. The eventual use of this
45intermediate value must yield an address within the bounds of the
46allocation, but such "exterior derived pointers" may be visible to the
47collector. Given this, a garbage collector can not safely rely on the
48runtime value of an address to indicate the object it is associated
49with. If the garbage collector wishes to move any object, the
50compiler must provide a mapping, for each pointer, to an indication of
51its allocation.
Philip Reamesf6123222014-12-02 19:37:00 +000052
Philip Reamesdfc238b2015-01-02 19:46:49 +000053To simplify the interaction between a collector and the compiled code,
54most garbage collectors are organized in terms of three abstractions:
55load barriers, store barriers, and safepoints.
Philip Reamesf6123222014-12-02 19:37:00 +000056
Philip Reamesdfc238b2015-01-02 19:46:49 +000057#. A load barrier is a bit of code executed immediately after the
58 machine load instruction, but before any use of the value loaded.
59 Depending on the collector, such a barrier may be needed for all
60 loads, merely loads of a particular type (in the original source
61 language), or none at all.
Philip Reamesf6123222014-12-02 19:37:00 +000062
Bruce Mitchenere9ffb452015-09-12 01:17:08 +000063#. Analogously, a store barrier is a code fragment that runs
Philip Reamesdfc238b2015-01-02 19:46:49 +000064 immediately before the machine store instruction, but after the
65 computation of the value stored. The most common use of a store
66 barrier is to update a 'card table' in a generational garbage
67 collector.
Philip Reamesf6123222014-12-02 19:37:00 +000068
Philip Reamesdfc238b2015-01-02 19:46:49 +000069#. A safepoint is a location at which pointers visible to the compiled
70 code (i.e. currently in registers or on the stack) are allowed to
71 change. After the safepoint completes, the actual pointer value
72 may differ, but the 'object' (as seen by the source language)
73 pointed to will not.
Philip Reamesf6123222014-12-02 19:37:00 +000074
Philip Reamesdfc238b2015-01-02 19:46:49 +000075 Note that the term 'safepoint' is somewhat overloaded. It refers to
76 both the location at which the machine state is parsable and the
77 coordination protocol involved in bring application threads to a
78 point at which the collector can safely use that information. The
79 term "statepoint" as used in this document refers exclusively to the
80 former.
Philip Reamesf6123222014-12-02 19:37:00 +000081
Philip Reamesdfc238b2015-01-02 19:46:49 +000082This document focuses on the last item - compiler support for
83safepoints in generated code. We will assume that an outside
84mechanism has decided where to place safepoints. From our
85perspective, all safepoints will be function calls. To support
86relocation of objects directly reachable from values in compiled code,
87the collector must be able to:
88
89#. identify every copy of a pointer (including copies introduced by
90 the compiler itself) at the safepoint,
Philip Reamesf6123222014-12-02 19:37:00 +000091#. identify which object each pointer relates to, and
92#. potentially update each of those copies.
93
Philip Reamesdfc238b2015-01-02 19:46:49 +000094This document describes the mechanism by which an LLVM based compiler
95can provide this information to a language runtime/collector, and
Philip Reames78b46452018-11-08 22:56:41 +000096ensure that all pointers can be read and updated if desired.
97
98Abstract Machine Model
99^^^^^^^^^^^^^^^^^^^^^^^
Philip Reames0d98ada2017-04-19 23:16:13 +0000100
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800101At a high level, LLVM has been extended to support compiling to an abstract
102machine which extends the actual target with a non-integral pointer type
103suitable for representing a garbage collected reference to an object. In
104particular, such non-integral pointer type have no defined mapping to an
105integer representation. This semantic quirk allows the runtime to pick a
106integer mapping for each point in the program allowing relocations of objects
Philip Reames0d98ada2017-04-19 23:16:13 +0000107without visible effects.
108
Philip Reames78b46452018-11-08 22:56:41 +0000109This high level abstract machine model is used for most of the optimizer. As
110a result, transform passes do not need to be extended to look through explicit
111relocation sequence. Before starting code generation, we switch
112representations to an explicit form. The exact location chosen for lowering
113is an implementation detail.
114
115Note that most of the value of the abstract machine model comes for collectors
116which need to model potentially relocatable objects. For a compiler which
117supports only a non-relocating collector, you may wish to consider starting
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800118with the fully explicit form.
Philip Reames0d98ada2017-04-19 23:16:13 +0000119
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800120Warning: There is one currently known semantic hole in the definition of
Philip Reames0d98ada2017-04-19 23:16:13 +0000121non-integral pointers which has not been addressed upstream. To work around
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800122this, you need to disable speculation of loads unless the memory type
123(non-integral pointer vs anything else) is known to unchanged. That is, it is
124not safe to speculate a load if doing causes a non-integral pointer value to
125be loaded as any other type or vice versa. In practice, this restriction is
Philip Reames0d98ada2017-04-19 23:16:13 +0000126well isolated to isSafeToSpeculate in ValueTracking.cpp.
127
Philip Reames78b46452018-11-08 22:56:41 +0000128Explicit Representation
129^^^^^^^^^^^^^^^^^^^^^^^
130
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800131A frontend could directly generate this low level explicit form, but
Philip Reames78b46452018-11-08 22:56:41 +0000132doing so may inhibit optimization. Instead, it is recommended that
133compilers with relocating collectors target the abstract machine model just
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800134described.
Philip Reames0d98ada2017-04-19 23:16:13 +0000135
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800136The heart of the explicit approach is to construct (or rewrite) the IR in a
Philip Reames0d98ada2017-04-19 23:16:13 +0000137manner where the possible updates performed by the garbage collector are
Philip Reamesdfc238b2015-01-02 19:46:49 +0000138explicitly visible in the IR. Doing so requires that we:
Philip Reamesf6123222014-12-02 19:37:00 +0000139
Philip Reamesdfc238b2015-01-02 19:46:49 +0000140#. create a new SSA value for each potentially relocated pointer, and
141 ensure that no uses of the original (non relocated) value is
142 reachable after the safepoint,
143#. specify the relocation in a way which is opaque to the compiler to
144 ensure that the optimizer can not introduce new uses of an
145 unrelocated value after a statepoint. This prevents the optimizer
146 from performing unsound optimizations.
147#. recording a mapping of live pointers (and the allocation they're
148 associated with) for each statepoint.
Philip Reamesf6123222014-12-02 19:37:00 +0000149
Philip Reamesdfc238b2015-01-02 19:46:49 +0000150At the most abstract level, inserting a safepoint can be thought of as
151replacing a call instruction with a call to a multiple return value
152function which both calls the original target of the call, returns
Sanjoy Das25e71d82017-04-19 23:55:03 +0000153its result, and returns updated values for any live pointers to
Philip Reamesdfc238b2015-01-02 19:46:49 +0000154garbage collected objects.
Philip Reamesf6123222014-12-02 19:37:00 +0000155
Philip Reamesdfc238b2015-01-02 19:46:49 +0000156 Note that the task of identifying all live pointers to garbage
157 collected values, transforming the IR to expose a pointer giving the
158 base object for every such live pointer, and inserting all the
159 intrinsics correctly is explicitly out of scope for this document.
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800160 The recommended approach is to use the :ref:`utility passes
161 <statepoint-utilities>` described below.
Philip Reamesf6123222014-12-02 19:37:00 +0000162
Philip Reamesdfc238b2015-01-02 19:46:49 +0000163This abstract function call is concretely represented by a sequence of
Philip Reames5017ab52015-02-26 01:18:21 +0000164intrinsic calls known collectively as a "statepoint relocation sequence".
Philip Reamesf6123222014-12-02 19:37:00 +0000165
166Let's consider a simple call in LLVM IR:
Philip Reamesf6123222014-12-02 19:37:00 +0000167
Philip Reames5017ab52015-02-26 01:18:21 +0000168.. code-block:: llvm
Philip Reamesf6123222014-12-02 19:37:00 +0000169
Philip Reamesf05145c2024-08-26 13:15:28 -0700170 declare void @foo()
171 define ptr addrspace(1) @test1(ptr addrspace(1) %obj)
Philip Reames5017ab52015-02-26 01:18:21 +0000172 gc "statepoint-example" {
Philip Reamesf05145c2024-08-26 13:15:28 -0700173 call void @foo()
174 ret ptr addrspace(1) %obj
Philip Reames5017ab52015-02-26 01:18:21 +0000175 }
Philip Reamesf6123222014-12-02 19:37:00 +0000176
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800177Depending on our language we may need to allow a safepoint during the execution
178of ``foo``. If so, we need to let the collector update local values in the
179current frame. If we don't, we'll be accessing a potential invalid reference
Philip Reames5017ab52015-02-26 01:18:21 +0000180once we eventually return from the call.
181
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800182In this example, we need to relocate the SSA value ``%obj``. Since we can't
183actually change the value in the SSA value ``%obj``, we need to introduce a new
Philip Reames5017ab52015-02-26 01:18:21 +0000184SSA value ``%obj.relocated`` which represents the potentially changed value of
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800185``%obj`` after the safepoint and update any following uses appropriately. The
Philip Reames5017ab52015-02-26 01:18:21 +0000186resulting relocation sequence is:
187
Nuno Lopese02fcee2017-07-26 14:11:23 +0000188.. code-block:: llvm
Philip Reames5017ab52015-02-26 01:18:21 +0000189
Philip Reamesf05145c2024-08-26 13:15:28 -0700190 define ptr addrspace(1) @test(ptr addrspace(1) %obj)
Philip Reames5017ab52015-02-26 01:18:21 +0000191 gc "statepoint-example" {
Philip Reamesf05145c2024-08-26 13:15:28 -0700192 %safepoint = call token (i64, i32, ptr, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, ptr elementtype(void ()) @foo, i32 0, i32 0, i32 0, i32 0) ["gc-live" (ptr addrspace(1) %obj)]
193 %obj.relocated = call ptr addrspace(1) @llvm.experimental.gc.relocate.p1(token %safepoint, i32 0, i32 0)
194 ret ptr addrspace(1) %obj.relocated
Philip Reames5017ab52015-02-26 01:18:21 +0000195 }
Philip Reamesf6123222014-12-02 19:37:00 +0000196
Philip Reamesdfc238b2015-01-02 19:46:49 +0000197Ideally, this sequence would have been represented as a M argument, N
198return value function (where M is the number of values being
199relocated + the original call arguments and N is the original return
200value + each relocated value), but LLVM does not easily support such a
201representation.
202
203Instead, the statepoint intrinsic marks the actual site of the
204safepoint or statepoint. The statepoint returns a token value (which
205exists only at compile time). To get back the original return value
Philip Reames5017ab52015-02-26 01:18:21 +0000206of the call, we use the ``gc.result`` intrinsic. To get the relocation
207of each pointer in turn, we use the ``gc.relocate`` intrinsic with the
208appropriate index. Note that both the ``gc.relocate`` and ``gc.result`` are
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800209tied to the statepoint. The combination forms a "statepoint relocation
Bruce Mitchenere9ffb452015-09-12 01:17:08 +0000210sequence" and represents the entirety of a parseable call or 'statepoint'.
Philip Reamesf6123222014-12-02 19:37:00 +0000211
Philip Reames5017ab52015-02-26 01:18:21 +0000212When lowered, this example would generate the following x86 assembly:
213
214.. code-block:: gas
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800215
Philip Reames5017ab52015-02-26 01:18:21 +0000216 .globl test1
217 .align 16, 0x90
218 pushq %rax
219 callq foo
220 .Ltmp1:
221 movq (%rsp), %rax # This load is redundant (oops!)
222 popq %rdx
223 retq
Philip Reamesf6123222014-12-02 19:37:00 +0000224
Philip Reamesdfc238b2015-01-02 19:46:49 +0000225Each of the potentially relocated values has been spilled to the
226stack, and a record of that location has been recorded to the
Philip Reames5017ab52015-02-26 01:18:21 +0000227:ref:`Stack Map section <stackmap-section>`. If the garbage collector
Philip Reamesdfc238b2015-01-02 19:46:49 +0000228needs to update any of these pointers during the call, it knows
229exactly what to change.
Philip Reamesf6123222014-12-02 19:37:00 +0000230
Philip Reames5017ab52015-02-26 01:18:21 +0000231The relevant parts of the StackMap section for our example are:
232
233.. code-block:: gas
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800234
Philip Reames5017ab52015-02-26 01:18:21 +0000235 # This describes the call site
236 # Stack Maps: callsite 2882400000
237 .quad 2882400000
238 .long .Ltmp1-test1
239 .short 0
240 # .. 8 entries skipped ..
241 # This entry describes the spill slot which is directly addressable
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800242 # off RSP with offset 0. Given the value was spilled with a pushq,
Philip Reames5017ab52015-02-26 01:18:21 +0000243 # that makes sense.
244 # Stack Maps: Loc 8: Direct RSP [encoding: .byte 2, .byte 8, .short 7, .int 0]
245 .byte 2
246 .byte 8
247 .short 7
248 .long 0
249
Sanjoy Das25e71d82017-04-19 23:55:03 +0000250This example was taken from the tests for the :ref:`RewriteStatepointsForGC`
251utility pass. As such, its full StackMap can be easily examined with the
252following command.
Philip Reames5017ab52015-02-26 01:18:21 +0000253
254.. code-block:: bash
255
256 opt -rewrite-statepoints-for-gc test/Transforms/RewriteStatepointsForGC/basics.ll -S | llc -debug-only=stackmaps
257
Philip Reamese777f012018-11-08 23:07:04 +0000258Simplifications for Non-Relocating GCs
259^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
260
261Some of the complexity in the previous example is unnecessary for a
262non-relocating collector. While a non-relocating collector still needs the
263information about which location contain live references, it doesn't need to
264represent explicit relocations. As such, the previously described explicit
265lowering can be simplified to remove all of the ``gc.relocate`` intrinsic
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800266calls and leave uses in terms of the original reference value.
Philip Reamese777f012018-11-08 23:07:04 +0000267
268Here's the explicit lowering for the previous example for a non-relocating
269collector:
270
271.. code-block:: llvm
272
Philip Reamesf05145c2024-08-26 13:15:28 -0700273 define void @manual_frame(ptr %a, ptr %b) gc "statepoint-example" {
274 %alloca = alloca ptr
275 %allocb = alloca ptr
276 store ptr %a, ptr %alloca
277 store ptr %b, ptr %allocb
278 call token (i64, i32, ptr, i32, i32, ...) @llvm.experimental.gc.statepoint.p0(i64 0, i32 0, ptr elementtype(void ()) @func, i32 0, i32 0, i32 0, i32 0) ["gc-live" (ptr %alloca, ptr %allocb)]
279 ret void
Philip Reamese777f012018-11-08 23:07:04 +0000280 }
281
Philip Reames8c7b7872018-11-08 23:20:40 +0000282Recording On Stack Regions
283^^^^^^^^^^^^^^^^^^^^^^^^^^
284
285In addition to the explicit relocation form previously described, the
286statepoint infrastructure also allows the listing of allocas within the gc
287pointer list. Allocas can be listed with or without additional explicit gc
288pointer values and relocations.
289
290An alloca in the gc region of the statepoint operand list will cause the
291address of the stack region to be listed in the stackmap for the statepoint.
292
293This mechanism can be used to describe explicit spill slots if desired. It
294then becomes the generator's responsibility to ensure that values are
295spill/filled to/from the alloca as needed on either side of the safepoint.
296Note that there is no way to indicate a corresponding base pointer for such
297an explicitly specified spill slot, so usage is restricted to values for
298which the associated collector can derive the object base from the pointer
299itself.
300
301This mechanism can be used to describe on stack objects containing
302references provided that the collector can map from the location on the
303stack to a heap map describing the internal layout of the references the
304collector needs to process.
305
306WARNING: At the moment, this alternate form is not well exercised. It is
307recommended to use this with caution and expect to have to fix a few bugs.
308In particular, the RewriteStatepointsForGC utility pass does not do
309anything for allocas today.
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800310
Philip Reamesc9e54442015-08-26 17:25:36 +0000311Base & Derived Pointers
312^^^^^^^^^^^^^^^^^^^^^^^
313
Philip Reamesca22b862015-08-26 23:13:35 +0000314A "base pointer" is one which points to the starting address of an allocation
315(object). A "derived pointer" is one which is offset from a base pointer by
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800316some amount. When relocating objects, a garbage collector needs to be able
317to relocate each derived pointer associated with an allocation to the same
Philip Reamesca22b862015-08-26 23:13:35 +0000318offset from the new address.
Philip Reamesc9e54442015-08-26 17:25:36 +0000319
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800320"Interior derived pointers" remain within the bounds of the allocation
321they're associated with. As a result, the base object can be found at
Philip Reamesca22b862015-08-26 23:13:35 +0000322runtime provided the bounds of allocations are known to the runtime system.
323
324"Exterior derived pointers" are outside the bounds of the associated object;
325they may even fall within *another* allocations address range. As a result,
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800326there is no way for a garbage collector to determine which allocation they
Philip Reamesca22b862015-08-26 23:13:35 +0000327are associated with at runtime and compiler support is needed.
328
329The ``gc.relocate`` intrinsic supports an explicit operand for describing the
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800330allocation associated with a derived pointer. This operand is frequently
Philip Reamesca22b862015-08-26 23:13:35 +0000331referred to as the base operand, but does not strictly speaking have to be
332a base pointer, but it does need to lie within the bounds of the associated
333allocation. Some collectors may require that the operand be an actual base
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800334pointer rather than merely an internal derived pointer. Note that during
335lowering both the base and derived pointer operands are required to be live
336over the associated call safepoint even if the base is otherwise unused
Philip Reamesca22b862015-08-26 23:13:35 +0000337afterwards.
338
Sanjoy Dasa34ce952016-01-20 19:50:25 +0000339.. _gc_transition_args:
Philip Reames5017ab52015-02-26 01:18:21 +0000340
Pat Gavlincc0431d2015-05-08 18:07:42 +0000341GC Transitions
342^^^^^^^^^^^^^^^^^^
Philip Reames5017ab52015-02-26 01:18:21 +0000343
Pat Gavlincc0431d2015-05-08 18:07:42 +0000344As a practical consideration, many garbage-collected systems allow code that is
345collector-aware ("managed code") to call code that is not collector-aware
346("unmanaged code"). It is common that such calls must also be safepoints, since
347it is desirable to allow the collector to run during the execution of
Sylvestre Ledru84666a12016-02-14 20:16:22 +0000348unmanaged code. Furthermore, it is common that coordinating the transition from
Pat Gavlincc0431d2015-05-08 18:07:42 +0000349managed to unmanaged code requires extra code generation at the call site to
350inform the collector of the transition. In order to support these needs, a
351statepoint may be marked as a GC transition, and data that is necessary to
352perform the transition (if any) may be provided as additional arguments to the
353statepoint.
354
355 Note that although in many cases statepoints may be inferred to be GC
356 transitions based on the function symbols involved (e.g. a call from a
357 function with GC strategy "foo" to a function with GC strategy "bar"),
358 indirect calls that are also GC transitions must also be supported. This
Bruce Mitchenere9ffb452015-09-12 01:17:08 +0000359 requirement is the driving force behind the decision to require that GC
Pat Gavlincc0431d2015-05-08 18:07:42 +0000360 transitions are explicitly marked.
361
362Let's revisit the sample given above, this time treating the call to ``@foo``
363as a GC transition. Depending on our target, the transition code may need to
364access some extra state in order to inform the collector of the transition.
365Let's assume a hypothetical GC--somewhat unimaginatively named "hypothetical-gc"
366--that requires that a TLS variable must be written to before and after a call
367to unmanaged code. The resulting relocation sequence is:
368
Nuno Lopese02fcee2017-07-26 14:11:23 +0000369.. code-block:: llvm
Pat Gavlincc0431d2015-05-08 18:07:42 +0000370
371 @flag = thread_local global i32 0, align 4
372
373 define i8 addrspace(1)* @test1(i8 addrspace(1) *%obj)
374 gc "hypothetical-gc" {
375
Chen Lid71999e2015-12-26 07:54:32 +0000376 %0 = call token (i64, i32, void ()*, i32, i32, ...)* @llvm.experimental.gc.statepoint.p0f_isVoidf(i64 0, i32 0, void ()* @foo, i32 0, i32 1, i32* @Flag, i32 0, i8 addrspace(1)* %obj)
377 %obj.relocated = call coldcc i8 addrspace(1)* @llvm.experimental.gc.relocate.p1i8(token %0, i32 7, i32 7)
Pat Gavlincc0431d2015-05-08 18:07:42 +0000378 ret i8 addrspace(1)* %obj.relocated
379 }
380
Kazu Hiratae8fa9012021-02-27 10:09:23 -0800381During lowering, this will result in an instruction selection DAG that looks
Pat Gavlincc0431d2015-05-08 18:07:42 +0000382something like:
383
Pat Gavlin7afaed22015-05-08 18:37:49 +0000384::
Pat Gavlincc0431d2015-05-08 18:07:42 +0000385
386 CALLSEQ_START
387 ...
388 GC_TRANSITION_START (lowered i32 *@Flag), SRCVALUE i32* Flag
389 STATEPOINT
390 GC_TRANSITION_END (lowered i32 *@Flag), SRCVALUE i32 *Flag
391 ...
392 CALLSEQ_END
393
394In order to generate the necessary transition code, the backend for each target
395supported by "hypothetical-gc" must be modified to lower ``GC_TRANSITION_START``
396and ``GC_TRANSITION_END`` nodes appropriately when the "hypothetical-gc"
397strategy is in use for a particular function. Assuming that such lowering has
398been added for X86, the generated assembly would be:
399
400.. code-block:: gas
401
402 .globl test1
403 .align 16, 0x90
404 pushq %rax
405 movl $1, %fs:Flag@TPOFF
406 callq foo
407 movl $0, %fs:Flag@TPOFF
408 .Ltmp1:
409 movq (%rsp), %rax # This load is redundant (oops!)
410 popq %rdx
411 retq
412
413Note that the design as presented above is not fully implemented: in particular,
414strategy-specific lowering is not present, and all GC transitions are emitted as
415as single no-op before and after the call instruction. These no-ops are often
416removed by the backend during dead machine instruction elimination.
Philip Reames5017ab52015-02-26 01:18:21 +0000417
Yevgeny Rouban4d26f412021-05-27 09:01:55 +0700418Before the abstract machine model is lowered to the explicit statepoint model
419of relocations by the :ref:`RewriteStatepointsForGC` pass it is possible for
420any derived pointer to get its base pointer and offset from the base pointer
421by using the ``gc.get.pointer.base`` and the ``gc.get.pointer.offset``
422intrinsics respectively. These intrinsics are inlined by the
423:ref:`RewriteStatepointsForGC` pass and must not be used after this pass.
424
Philip Reames5017ab52015-02-26 01:18:21 +0000425
Philip Reamese6625502015-02-25 23:22:43 +0000426.. _statepoint-stackmap-format:
Philip Reamesf6123222014-12-02 19:37:00 +0000427
Philip Reamesce5ff372014-12-04 00:45:23 +0000428Stack Map Format
Philip Reamesf6123222014-12-02 19:37:00 +0000429================
430
Philip Reamesdfc238b2015-01-02 19:46:49 +0000431Locations for each pointer value which may need read and/or updated by
Philip Reames4c455612018-11-08 15:17:10 +0000432the runtime or collector are provided in a separate section of the
Philip Reames9ffd5eb2018-11-08 17:20:35 +0000433generated object file as specified in the PatchPoint documentation.
434This special section is encoded per the
Philip Reames4c455612018-11-08 15:17:10 +0000435:ref:`Stack Map format <stackmap-format>`.
436
437The general expectation is that a JIT compiler will parse and discard this
438format; it is not particularly memory efficient. If you need an alternate
439format (e.g. for an ahead of time compiler), see discussion under
440:ref: `open work items <OpenWork>` below.
Philip Reamesf6123222014-12-02 19:37:00 +0000441
442Each statepoint generates the following Locations:
443
Pat Gavlinc7dc6d6ee2015-05-12 19:50:19 +0000444* Constant which describes the calling convention of the call target. This
445 constant is a valid :ref:`calling convention identifier <callingconv>` for
446 the version of LLVM used to generate the stackmap. No additional compatibility
447 guarantees are made for this constant over what LLVM provides elsewhere w.r.t.
448 these identifiers.
449* Constant which describes the flags passed to the statepoint intrinsic
Philip Reamesdfc238b2015-01-02 19:46:49 +0000450* Constant which describes number of following deopt *Locations* (not
Philip Reamesa96fc462020-08-14 16:06:19 -0700451 operands). Will be 0 if no "deopt" bundle is provided.
452* Variable number of Locations, one for each deopt parameter listed in the
453 "deopt" operand bundle. At the moment, only deopt parameters with a bitwidth
454 of 64 bits or less are supported. Values of a type larger than 64 bits can be
455 specified and reported only if a) the value is constant at the call site, and
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800456 b) the constant can be represented with less than 64 bits (assuming zero
Philip Reames95e363d2016-01-14 23:58:18 +0000457 extension to the original bitwidth).
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800458* Variable number of relocation records, each of which consists of
Philip Reames35bafee2016-01-15 00:13:39 +0000459 exactly two Locations. Relocation records are described in detail
460 below.
461
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800462Each relocation record provides sufficient information for a collector to
463relocate one or more derived pointers. Each record consists of a pair of
464Locations. The second element in the record represents the pointer (or
465pointers) which need updated. The first element in the record provides a
Philip Reames35bafee2016-01-15 00:13:39 +0000466pointer to the base of the object with which the pointer(s) being relocated is
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800467associated. This information is required for handling generalized derived
Philip Reames35bafee2016-01-15 00:13:39 +0000468pointers since a pointer may be outside the bounds of the original allocation,
469but still needs to be relocated with the allocation. Additionally:
470
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800471* It is guaranteed that the base pointer must also appear explicitly as a
472 relocation pair if used after the statepoint.
Philip Reames35bafee2016-01-15 00:13:39 +0000473* There may be fewer relocation records then gc parameters in the IR
Philip Reamesdfc238b2015-01-02 19:46:49 +0000474 statepoint. Each *unique* pair will occur at least once; duplicates
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800475 are possible.
476* The Locations within each record may either be of pointer size or a
477 multiple of pointer size. In the later case, the record must be
478 interpreted as describing a sequence of pointers and their corresponding
Philip Reames35bafee2016-01-15 00:13:39 +0000479 base pointers. If the Location is of size N x sizeof(pointer), then
480 there will be N records of one pointer each contained within the Location.
481 Both Locations in a pair can be assumed to be of the same size.
Philip Reamesf6123222014-12-02 19:37:00 +0000482
Philip Reamesdfc238b2015-01-02 19:46:49 +0000483Note that the Locations used in each section may describe the same
484physical location. e.g. A stack slot may appear as a deopt location,
485a gc base pointer, and a gc derived pointer.
Philip Reamesf6123222014-12-02 19:37:00 +0000486
Philip Reamesdfc238b2015-01-02 19:46:49 +0000487The LiveOut section of the StkMapRecord will be empty for a statepoint
488record.
Philip Reamesf6123222014-12-02 19:37:00 +0000489
490Safepoint Semantics & Verification
491==================================
492
Philip Reamesdfc238b2015-01-02 19:46:49 +0000493The fundamental correctness property for the compiled code's
494correctness w.r.t. the garbage collector is a dynamic one. It must be
Kazu Hiratae8fa9012021-02-27 10:09:23 -0800495the case that there is no dynamic trace such that an operation
Philip Reamesdfc238b2015-01-02 19:46:49 +0000496involving a potentially relocated pointer is observably-after a
497safepoint which could relocate it. 'observably-after' is this usage
498means that an outside observer could observe this sequence of events
499in a way which precludes the operation being performed before the
500safepoint.
Philip Reamesf6123222014-12-02 19:37:00 +0000501
Philip Reamesdfc238b2015-01-02 19:46:49 +0000502To understand why this 'observable-after' property is required,
503consider a null comparison performed on the original copy of a
504relocated pointer. Assuming that control flow follows the safepoint,
505there is no way to observe externally whether the null comparison is
506performed before or after the safepoint. (Remember, the original
507Value is unmodified by the safepoint.) The compiler is free to make
508either scheduling choice.
Philip Reamesf6123222014-12-02 19:37:00 +0000509
Philip Reamesdfc238b2015-01-02 19:46:49 +0000510The actual correctness property implemented is slightly stronger than
511this. We require that there be no *static path* on which a
512potentially relocated pointer is 'observably-after' it may have been
513relocated. This is slightly stronger than is strictly necessary (and
514thus may disallow some otherwise valid programs), but greatly
515simplifies reasoning about correctness of the compiled code.
Philip Reamesf6123222014-12-02 19:37:00 +0000516
Philip Reamesdfc238b2015-01-02 19:46:49 +0000517By construction, this property will be upheld by the optimizer if
518correctly established in the source IR. This is a key invariant of
519the design.
Philip Reamesf6123222014-12-02 19:37:00 +0000520
Philip Reamesdfc238b2015-01-02 19:46:49 +0000521The existing IR Verifier pass has been extended to check most of the
522local restrictions on the intrinsics mentioned in their respective
523documentation. The current implementation in LLVM does not check the
524key relocation invariant, but this is ongoing work on developing such
Tanya Lattner0d28f802015-08-05 03:51:17 +0000525a verifier. Please ask on llvm-dev if you're interested in
Philip Reamesdfc238b2015-01-02 19:46:49 +0000526experimenting with the current version.
Philip Reamesf6123222014-12-02 19:37:00 +0000527
Philip Reamesc88d7322015-02-25 01:23:59 +0000528.. _statepoint-utilities:
529
530Utility Passes for Safepoint Insertion
531======================================
532
533.. _RewriteStatepointsForGC:
534
535RewriteStatepointsForGC
536^^^^^^^^^^^^^^^^^^^^^^^^
537
Philip Reames0d98ada2017-04-19 23:16:13 +0000538The pass RewriteStatepointsForGC transforms a function's IR to lower from the
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800539abstract machine model described above to the explicit statepoint model of
Philip Reames0d98ada2017-04-19 23:16:13 +0000540relocations. To do this, it replaces all calls or invokes of functions which
541might contain a safepoint poll with a ``gc.statepoint`` and associated full
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800542relocation sequence, including all required ``gc.relocates``.
Philip Reames0d98ada2017-04-19 23:16:13 +0000543
Campbell Suter7092dae2023-01-25 17:12:19 +0300544This pass only applies to GCStrategy instances where the ``UseRS4GC`` flag
545is set. The two builtin GC strategies with this set are the
546"statepoint-example" and "coreclr" strategies.
Philip Reamesc88d7322015-02-25 01:23:59 +0000547
548As an example, given this code:
549
Nuno Lopese02fcee2017-07-26 14:11:23 +0000550.. code-block:: llvm
Philip Reamesc88d7322015-02-25 01:23:59 +0000551
Philip Reamesf05145c2024-08-26 13:15:28 -0700552 define ptr addrspace(1) @test1(ptr addrspace(1) %obj)
Philip Reamesc88d7322015-02-25 01:23:59 +0000553 gc "statepoint-example" {
Philip Reames0d98ada2017-04-19 23:16:13 +0000554 call void @foo()
Philip Reamesf05145c2024-08-26 13:15:28 -0700555 ret ptr addrspace(1) %obj
Philip Reamesc88d7322015-02-25 01:23:59 +0000556 }
557
558The pass would produce this IR:
559
Nuno Lopese02fcee2017-07-26 14:11:23 +0000560.. code-block:: llvm
Philip Reamesc88d7322015-02-25 01:23:59 +0000561
Philip Reamesf05145c2024-08-26 13:15:28 -0700562 define ptr addrspace(1) @test_rs4gc(ptr addrspace(1) %obj) gc "statepoint-example" {
563 %statepoint_token = call token (i64, i32, ptr, i32, i32, ...) @llvm.experimental.gc.statepoint.p0(i64 2882400000, i32 0, ptr elementtype(void ()) @foo, i32 0, i32 0, i32 0, i32 0) [ "gc-live"(ptr addrspace(1) %obj) ]
564 %obj.relocated = call coldcc ptr addrspace(1) @llvm.experimental.gc.relocate.p1(token %statepoint_token, i32 0, i32 0) ; (%obj, %obj)
565 ret ptr addrspace(1) %obj.relocated
Philip Reamesc88d7322015-02-25 01:23:59 +0000566 }
567
568In the above examples, the addrspace(1) marker on the pointers is the mechanism
569that the ``statepoint-example`` GC strategy uses to distinguish references from
Campbell Suter7092dae2023-01-25 17:12:19 +0300570non references. This is controlled via GCStrategy::isGCManagedPointer. The
571``statepoint-example`` and ``coreclr`` strategies (the only two default
572strategies that support statepoints) both use addrspace(1) to determine which
573pointers are references, however custom strategies don't have to follow this
574convention.
Philip Reamesc88d7322015-02-25 01:23:59 +0000575
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800576This pass can be used an utility function by a language frontend that doesn't
577want to manually reason about liveness, base pointers, or relocation when
578constructing IR. As currently implemented, RewriteStatepointsForGC must be
Philip Reamesca22b862015-08-26 23:13:35 +0000579run after SSA construction (i.e. mem2ref).
Philip Reamesc88d7322015-02-25 01:23:59 +0000580
Philip Reamesca22b862015-08-26 23:13:35 +0000581RewriteStatepointsForGC will ensure that appropriate base pointers are listed
582for every relocation created. It will do so by duplicating code as needed to
583propagate the base pointer associated with each pointer being relocated to
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800584the appropriate safepoints. The implementation assumes that the following
585IR constructs produce base pointers: loads from the heap, addresses of global
Philip Reamesca22b862015-08-26 23:13:35 +0000586variables, function arguments, function return values. Constant pointers (such
587as null) are also assumed to be base pointers. In practice, this constraint
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800588can be relaxed to producing interior derived pointers provided the target
589collector can find the associated allocation from an arbitrary interior
Philip Reamesca22b862015-08-26 23:13:35 +0000590derived pointer.
Philip Reamesc88d7322015-02-25 01:23:59 +0000591
Philip Reames0d98ada2017-04-19 23:16:13 +0000592By default RewriteStatepointsForGC passes in ``0xABCDEF00`` as the statepoint
593ID and ``0`` as the number of patchable bytes to the newly constructed
594``gc.statepoint``. These values can be configured on a per-callsite
595basis using the attributes ``"statepoint-id"`` and
596``"statepoint-num-patch-bytes"``. If a call site is marked with a
597``"statepoint-id"`` function attribute and its value is a positive
598integer (represented as a string), then that value is used as the ID
599of the newly constructed ``gc.statepoint``. If a call site is marked
600with a ``"statepoint-num-patch-bytes"`` function attribute and its
601value is a positive integer, then that value is used as the 'num patch
602bytes' parameter of the newly constructed ``gc.statepoint``. The
603``"statepoint-id"`` and ``"statepoint-num-patch-bytes"`` attributes
604are not propagated to the ``gc.statepoint`` call or invoke if they
605could be successfully parsed.
606
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800607In practice, RewriteStatepointsForGC should be run much later in the pass
608pipeline, after most optimization is already done. This helps to improve
Philip Reamesc88d7322015-02-25 01:23:59 +0000609the quality of the generated code when compiled with garbage collection support.
Philip Reamesc88d7322015-02-25 01:23:59 +0000610
Artur Pilipenko6ec2c5e2020-10-01 20:05:23 -0700611.. _RewriteStatepointsForGC_intrinsic_lowering:
612
613RewriteStatepointsForGC intrinsic lowering
614^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
615
616As a part of lowering to the explicit model of relocations
Yevgeny Rouban4d26f412021-05-27 09:01:55 +0700617RewriteStatepointsForGC performs GC specific lowering for the following
618intrinsics:
Artur Pilipenko6ec2c5e2020-10-01 20:05:23 -0700619
Yevgeny Rouban4d26f412021-05-27 09:01:55 +0700620* ``gc.get.pointer.base``
621* ``gc.get.pointer.offset``
622* ``llvm.memcpy.element.unordered.atomic.*``
623* ``llvm.memmove.element.unordered.atomic.*``
624
625There are two possible lowerings for the memcpy and memmove operations:
626GC leaf lowering and GC parseable lowering. If a call is explicitly marked with
Artur Pilipenko6ec2c5e2020-10-01 20:05:23 -0700627"gc-leaf-function" attribute the call is lowered to a GC leaf call to
628'``__llvm_memcpy_element_unordered_atomic_*``' or
629'``__llvm_memmove_element_unordered_atomic_*``' symbol. Such a call can not
630take a safepoint. Otherwise, the call is made GC parseable by wrapping the
631call into a statepoint. This makes it possible to take a safepoint during
632copy operation. Note that a GC parseable copy operation is not required to
633take a safepoint. For example, a short copy operation may be performed without
634taking a safepoint.
635
636GC parseable calls to '``llvm.memcpy.element.unordered.atomic.*``',
637'``llvm.memmove.element.unordered.atomic.*``' intrinsics are lowered to calls
638to '``__llvm_memcpy_element_unordered_atomic_safepoint_*``',
639'``__llvm_memmove_element_unordered_atomic_safepoint_*``' symbols respectively.
640This way the runtime can provide implementations of copy operations with and
641without safepoints.
642
643GC parseable lowering also involves adjusting the arguments for the call.
644Memcpy and memmove intrinsics take derived pointers as source and destination
645arguments. If a copy operation takes a safepoint it might need to relocate the
646underlying source and destination objects. This requires the corresponding base
647pointers to be available in the copy operation. In order to make the base
648pointers available RewriteStatepointsForGC replaces derived pointers with base
649pointer and offset pairs. For example:
650
651.. code-block:: llvm
652
653 declare void @__llvm_memcpy_element_unordered_atomic_safepoint_1(
654 i8 addrspace(1)* %dest_base, i64 %dest_offset,
655 i8 addrspace(1)* %src_base, i64 %src_offset,
656 i64 %length)
657
658
Philip Reamesfe755af2022-10-13 07:08:35 -0700659.. _PlaceSafepoints:
660
661PlaceSafepoints
662^^^^^^^^^^^^^^^^
663
664The pass PlaceSafepoints inserts safepoint polls sufficient to ensure running
665code checks for a safepoint request on a timely manner. This pass is expected
666to be run before RewriteStatepointsForGC and thus does not produce full
667relocation sequences.
668
669As an example, given input IR of the following:
670
671.. code-block:: llvm
672
673 define void @test() gc "statepoint-example" {
674 call void @foo()
675 ret void
676 }
677
678 declare void @do_safepoint()
679 define void @gc.safepoint_poll() {
680 call void @do_safepoint()
681 ret void
682 }
683
684
685This pass would produce the following IR:
686
687.. code-block:: llvm
688
689 define void @test() gc "statepoint-example" {
690 call void @do_safepoint()
691 call void @foo()
692 ret void
693 }
694
695In this case, we've added an (unconditional) entry safepoint poll. Note that
696despite appearances, the entry poll is not necessarily redundant. We'd have to
697know that ``foo`` and ``test`` were not mutually recursive for the poll to be
698redundant. In practice, you'd probably want to your poll definition to contain
699a conditional branch of some form.
700
701At the moment, PlaceSafepoints can insert safepoint polls at method entry and
702loop backedges locations. Extending this to work with return polls would be
703straight forward if desired.
704
705PlaceSafepoints includes a number of optimizations to avoid placing safepoint
706polls at particular sites unless needed to ensure timely execution of a poll
707under normal conditions. PlaceSafepoints does not attempt to ensure timely
708execution of a poll under worst case conditions such as heavy system paging.
709
710The implementation of a safepoint poll action is specified by looking up a
711function of the name ``gc.safepoint_poll`` in the containing Module. The body
712of this function is inserted at each poll site desired. While calls or invokes
713inside this method are transformed to a ``gc.statepoints``, recursive poll
714insertion is not performed.
715
716This pass is useful for any language frontend which only has to support
717garbage collection semantics at safepoints. If you need other abstract
718frame information at safepoints (e.g. for deoptimization or introspection),
719you can insert safepoint polls in the frontend. If you have the later case,
720please ask on llvm-dev for suggestions. There's been a good amount of work
721done on making such a scheme work well in practice which is not yet documented
722here.
723
724
Philip Reamesb7736312015-07-16 21:10:46 +0000725Supported Architectures
726=======================
727
728Support for statepoint generation requires some code for each backend.
Markus Böcke101eb52022-02-13 11:14:42 +0100729Today, only Aarch64 and X86_64 are supported.
Philip Reames4c455612018-11-08 15:17:10 +0000730
731.. _OpenWork:
Philip Reamesb7736312015-07-16 21:10:46 +0000732
Philip Reames50320812018-11-09 17:09:16 +0000733Limitations and Half Baked Ideas
734================================
Philip Reames2e7383c2016-03-03 23:24:44 +0000735
Philip Reames50320812018-11-09 17:09:16 +0000736Mixing References and Raw Pointers
737^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Philip Reames2e7383c2016-03-03 23:24:44 +0000738
Philip Reames50320812018-11-09 17:09:16 +0000739Support for languages which allow unmanaged pointers to garbage collected
740objects (i.e. pass a pointer to an object to a C routine) in the abstract
741machine model. At the moment, the best idea on how to approach this
742involves an intrinsic or opaque function which hides the connection between
743the reference value and the raw pointer. The problem is that having a
744ptrtoint or inttoptr cast (which is common for such use cases) breaks the
745rules used for inferring base pointers for arbitrary references when
746lowering out of the abstract model to the explicit physical model. Note
747that a frontend which lowers directly to the physical model doesn't have
748any problems here.
Philip Reames2e7383c2016-03-03 23:24:44 +0000749
Philip Reames50320812018-11-09 17:09:16 +0000750Objects on the Stack
751^^^^^^^^^^^^^^^^^^^^
Philip Reames2e7383c2016-03-03 23:24:44 +0000752
Philip Reames50320812018-11-09 17:09:16 +0000753As noted above, the explicit lowering supports objects allocated on the
754stack provided the collector can find a heap map given the stack address.
Philip Reames2e7383c2016-03-03 23:24:44 +0000755
Philip Reames50320812018-11-09 17:09:16 +0000756The missing pieces are a) integration with rewriting (RS4GC) from the
757abstract machine model and b) support for optionally decomposing on stack
758objects so as not to require heap maps for them. The later is required
Shao-Ce SUN0c660252021-11-15 09:17:08 +0800759for ease of integration with some collectors.
Philip Reames2e7383c2016-03-03 23:24:44 +0000760
Philip Reames50320812018-11-09 17:09:16 +0000761Lowering Quality and Representation Overhead
762^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
763
764The current statepoint lowering is known to be somewhat poor. In the very
765long term, we'd like to integrate statepoints with the register allocator;
766in the near term this is unlikely to happen. We've found the quality of
767lowering to be relatively unimportant as hot-statepoints are almost always
768inliner bugs.
769
770Concerns have been raised that the statepoint representation results in a
771large amount of IR being produced for some examples and that this
772contributes to higher than expected memory usage and compile times. There's
773no immediate plans to make changes due to this, but alternate models may be
774explored in the future.
775
776Relocations Along Exceptional Edges
777^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
778
779Relocations along exceptional paths are currently broken in ToT. In
780particular, there is current no way to represent a rethrow on a path which
781also has relocations. See `this llvm-dev discussion
782<https://groups.google.com/forum/#!topic/llvm-dev/AE417XjgxvI>`_ for more
783detail.
784
Philip Reames83331522014-12-04 18:33:28 +0000785Bugs and Enhancements
786=====================
Philip Reamesdfc238b2015-01-02 19:46:49 +0000787
788Currently known bugs and enhancements under consideration can be
789tracked by performing a `bugzilla search
Ismail Donmezc7ff8142017-02-17 08:26:11 +0000790<https://bugs.llvm.org/buglist.cgi?cmdtype=runnamed&namedcmd=Statepoint%20Bugs&list_id=64342>`_
Philip Reamesdfc238b2015-01-02 19:46:49 +0000791for [Statepoint] in the summary field. When filing new bugs, please
792use this tag so that interested parties see the newly filed bug. As
Tanya Lattnerb4990ac2022-02-21 18:58:48 -0800793with most LLVM features, design discussions take place on the `Discourse forums <https://discourse.llvm.org>`_ and patches
Philip Reamesdfc238b2015-01-02 19:46:49 +0000794should be sent to `llvm-commits
Tanya Lattner0d28f802015-08-05 03:51:17 +0000795<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_ for review.