[lit] Refine filter error handling
Picking a default filter `.*` that matches everything lets us streamline
some error handling code.
diff --git a/llvm/utils/lit/lit/cl_arguments.py b/llvm/utils/lit/lit/cl_arguments.py
index 53ef761..656a783 100644
--- a/llvm/utils/lit/lit/cl_arguments.py
+++ b/llvm/utils/lit/lit/cl_arguments.py
@@ -133,7 +133,7 @@
metavar="REGEX",
type=_case_insensitive_regex,
help="Only run tests with paths matching the given regular expression",
- default=os.environ.get("LIT_FILTER"))
+ default=os.environ.get("LIT_FILTER", ".*"))
selection_group.add_argument("--num-shards", # TODO(yln): --shards N/M
dest="numShards",
metavar="M",
diff --git a/llvm/utils/lit/lit/main.py b/llvm/utils/lit/lit/main.py
index a329115..8ac53df 100755
--- a/llvm/utils/lit/lit/main.py
+++ b/llvm/utils/lit/lit/main.py
@@ -57,22 +57,19 @@
print_suites_or_tests(discovered_tests, opts)
return
- if opts.filter:
- filtered_tests = [t for t in discovered_tests if
- opts.filter.search(t.getFullName())]
- if not filtered_tests:
- sys.stderr.write('error: filter did not match any tests '
- '(of %d discovered). ' % len(discovered_tests))
- if opts.allow_empty_runs:
- sys.stderr.write('Suppressing error because '
- "'--allow-empty-runs' was specified.\n")
- sys.exit(0)
- else:
- sys.stderr.write("Use '--allow-empty-runs' to suppress this "
- 'error.\n')
- sys.exit(2)
- else:
- filtered_tests = discovered_tests
+ filtered_tests = [t for t in discovered_tests if
+ opts.filter.search(t.getFullName())]
+ if not filtered_tests:
+ sys.stderr.write('error: filter did not match any tests '
+ '(of %d discovered). ' % len(discovered_tests))
+ if opts.allow_empty_runs:
+ sys.stderr.write("Suppressing error because '--allow-empty-runs' "
+ 'was specified.\n')
+ sys.exit(0)
+ else:
+ sys.stderr.write("Use '--allow-empty-runs' to suppress this "
+ 'error.\n')
+ sys.exit(2)
determine_order(filtered_tests, opts.order)
